gui: Remove "enum list_wrap" from list action functions

Removing the "list_wrap" argument is actually pretty easy.
In practice, almost all lists are using LIST_WRAP_UNLESS_HELD
behavior so we can make that the default. A couple of lists
disable wraparound with LIST_WRAP_OFF; this is now achieved
by setting the list "wraparound" flag to false when setting
up the list. LIST_WRAP_ON was unused and is of questionable
value, so it has been removed entirely.

This makes list wraparound behavior a property of the list,
controlled solely by the "wraparound" flag. The result is a
simpler list API and implementation, without changing the
behavior of any lists.

Change-Id: Ib55d17519e6d92fc95ae17b84ab0aaf4233bcb5a

1 files changed, 2 insertions, 11 deletions

diff --git a/apps/gui/list.h b/apps/gui/list.h
index 20410471a2..19f0ccbbff 100644
--- a/apps/gui/list.h
+++ b/apps/gui/list.h
@@ -30,12 +30,6 @@
 
 #define SCROLLBAR_WIDTH global_settings.scrollbar_width
 
-enum list_wrap {
-    LIST_WRAP_ON = 0,
-    LIST_WRAP_OFF,
-    LIST_WRAP_UNLESS_HELD,
-};
-
 enum synclist_cursor
 {
     SYNCLIST_CURSOR_NOSTYLE = 0,
@@ -238,9 +232,7 @@ extern bool gui_synclist_keyclick_callback(int action, void* data);
  * returns true if the action was handled.
  * NOTE: *action may be changed regardless of return value
  */
-extern bool gui_synclist_do_button(struct gui_synclist * lists,
-                                       int *action,
-                                       enum list_wrap);
+extern bool gui_synclist_do_button(struct gui_synclist * lists, int *action);
 #if !defined(PLUGIN)
 struct listitem_viewport_cfg {
     struct wps_data *data;
@@ -283,8 +275,7 @@ extern int list_do_action_timeout(struct gui_synclist *lists, int timeout);
    list_do_action_timeout) with the gui_synclist_do_button call, for
    convenience. */
 extern bool list_do_action(int context, int timeout,
-                           struct gui_synclist *lists, int *action,
-                           enum list_wrap wrap);
+                           struct gui_synclist *lists, int *action);
 
 
 /** Simplelist implementation.