diff options
author | Jonathan Gordon <rockbox@jdgordon.info> | 2006-08-15 14:06:29 +0000 |
---|---|---|
committer | Jonathan Gordon <rockbox@jdgordon.info> | 2006-08-15 14:06:29 +0000 |
commit | 599fa9a6279a4e7dda4b6a46bef6bf4958bb0399 (patch) | |
tree | a36e63624fad0bcdb926b2ef08dbcb68ba442307 /apps/gui/list.c | |
parent | b9fb0e81f1c702495c3dc73c2f59b965fdf9caae (diff) | |
download | rockbox-599fa9a6279a4e7dda4b6a46bef6bf4958bb0399.tar.gz rockbox-599fa9a6279a4e7dda4b6a46bef6bf4958bb0399.zip |
fix "off-by-one" bug in paginated scrolling with the title
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10589 a1c6a512-1295-4272-9138-f99709370657
Diffstat (limited to 'apps/gui/list.c')
-rw-r--r-- | apps/gui/list.c | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/apps/gui/list.c b/apps/gui/list.c index f48d4d9ee1..0d8b4d1879 100644 --- a/apps/gui/list.c +++ b/apps/gui/list.c | |||
@@ -377,11 +377,11 @@ void gui_list_select_next(struct gui_list * gui_list) | |||
377 | 377 | ||
378 | void gui_list_select_previous(struct gui_list * gui_list) | 378 | void gui_list_select_previous(struct gui_list * gui_list) |
379 | { | 379 | { |
380 | int nb_lines = gui_list->display->nb_lines; | ||
381 | if (gui_list->title) | ||
382 | nb_lines--; | ||
380 | if( gui_list->selected_item-gui_list->selected_size < 0 ) | 383 | if( gui_list->selected_item-gui_list->selected_size < 0 ) |
381 | { | 384 | { |
382 | int nb_lines = gui_list->display->nb_lines; | ||
383 | if (gui_list->title) | ||
384 | nb_lines--; | ||
385 | if(gui_list->limit_scroll) | 385 | if(gui_list->limit_scroll) |
386 | return; | 386 | return; |
387 | /* we have aleady reached the top of the list */ | 387 | /* we have aleady reached the top of the list */ |
@@ -396,7 +396,6 @@ void gui_list_select_previous(struct gui_list * gui_list) | |||
396 | else | 396 | else |
397 | { | 397 | { |
398 | int item_pos; | 398 | int item_pos; |
399 | int nb_lines = gui_list->display->nb_lines; | ||
400 | gui_list->selected_item-=gui_list->selected_size; | 399 | gui_list->selected_item-=gui_list->selected_size; |
401 | item_pos = gui_list->selected_item - gui_list->start_item; | 400 | item_pos = gui_list->selected_item - gui_list->start_item; |
402 | if (global_settings.scroll_paginated) | 401 | if (global_settings.scroll_paginated) |