diff options
author | Brandon Low <lostlogic@rockbox.org> | 2006-02-03 00:12:11 +0000 |
---|---|---|
committer | Brandon Low <lostlogic@rockbox.org> | 2006-02-03 00:12:11 +0000 |
commit | d2e75bf02d1ad91fca0e283e8c71b1091ec85a80 (patch) | |
tree | 49e59cc25f26b9bd9c97bcb37adfe05204b70119 /apps/codecs.h | |
parent | 9b0822d76a6f2f2dd1e28cef4a525d0fb752278e (diff) | |
download | rockbox-d2e75bf02d1ad91fca0e283e8c71b1091ec85a80.tar.gz rockbox-d2e75bf02d1ad91fca0e283e8c71b1091ec85a80.zip |
Remove exported pcm functions. Codecs should never be allowed to access
the pcm directly. Only through the callbacks in playback.c.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8544 a1c6a512-1295-4272-9138-f99709370657
Diffstat (limited to 'apps/codecs.h')
-rw-r--r-- | apps/codecs.h | 17 |
1 files changed, 5 insertions, 12 deletions
diff --git a/apps/codecs.h b/apps/codecs.h index 70799f790e..6e2ef9882c 100644 --- a/apps/codecs.h +++ b/apps/codecs.h | |||
@@ -48,7 +48,6 @@ | |||
48 | #endif | 48 | #endif |
49 | #if (CONFIG_CODEC == SWCODEC) | 49 | #if (CONFIG_CODEC == SWCODEC) |
50 | #include "dsp.h" | 50 | #include "dsp.h" |
51 | #include "pcm_playback.h" | ||
52 | #include "playback.h" | 51 | #include "playback.h" |
53 | #endif | 52 | #endif |
54 | #include "settings.h" | 53 | #include "settings.h" |
@@ -86,12 +85,12 @@ | |||
86 | #define CODEC_MAGIC 0x52434F44 /* RCOD */ | 85 | #define CODEC_MAGIC 0x52434F44 /* RCOD */ |
87 | 86 | ||
88 | /* increase this every time the api struct changes */ | 87 | /* increase this every time the api struct changes */ |
89 | #define CODEC_API_VERSION 2 | 88 | #define CODEC_API_VERSION 3 |
90 | 89 | ||
91 | /* update this to latest version if a change to the api struct breaks | 90 | /* update this to latest version if a change to the api struct breaks |
92 | backwards compatibility (and please take the opportunity to sort in any | 91 | backwards compatibility (and please take the opportunity to sort in any |
93 | new function which are "waiting" at the end of the function table) */ | 92 | new function which are "waiting" at the end of the function table) */ |
94 | #define CODEC_MIN_API_VERSION 1 | 93 | #define CODEC_MIN_API_VERSION 3 |
95 | 94 | ||
96 | /* codec return codes */ | 95 | /* codec return codes */ |
97 | enum codec_status { | 96 | enum codec_status { |
@@ -230,13 +229,6 @@ struct codec_api { | |||
230 | void (*mp3_play_pause)(bool play); | 229 | void (*mp3_play_pause)(bool play); |
231 | void (*mp3_play_stop)(void); | 230 | void (*mp3_play_stop)(void); |
232 | bool (*mp3_is_playing)(void); | 231 | bool (*mp3_is_playing)(void); |
233 | #if CONFIG_CODEC == SWCODEC | ||
234 | void (*pcm_play_data)(void (*get_more)(unsigned char** start, long*size)); | ||
235 | void (*pcm_play_stop)(void); | ||
236 | void (*pcm_set_frequency)(unsigned int frequency); | ||
237 | bool (*pcm_is_playing)(void); | ||
238 | void (*pcm_play_pause)(bool play); | ||
239 | #endif | ||
240 | #endif /* !SIMULATOR */ | 232 | #endif /* !SIMULATOR */ |
241 | 233 | ||
242 | /* playback control */ | 234 | /* playback control */ |
@@ -290,8 +282,6 @@ struct codec_api { | |||
290 | int (*battery_level)(void); | 282 | int (*battery_level)(void); |
291 | bool (*battery_level_safe)(void); | 283 | bool (*battery_level_safe)(void); |
292 | 284 | ||
293 | /* new stuff at the end, sort into place next time | ||
294 | the API gets incompatible */ | ||
295 | #ifdef RB_PROFILE | 285 | #ifdef RB_PROFILE |
296 | void (*profile_thread)(void); | 286 | void (*profile_thread)(void); |
297 | void (*profstop)(void); | 287 | void (*profstop)(void); |
@@ -299,6 +289,9 @@ struct codec_api { | |||
299 | void (*profile_func_exit)(void *this_fn, void *call_site); | 289 | void (*profile_func_exit)(void *this_fn, void *call_site); |
300 | #endif | 290 | #endif |
301 | 291 | ||
292 | /* new stuff at the end, sort into place next time | ||
293 | the API gets incompatible */ | ||
294 | |||
302 | }; | 295 | }; |
303 | 296 | ||
304 | /* codec header */ | 297 | /* codec header */ |