buffering: Fix a case that could allow widx to fully wrap to ridx and overflow the ringbuffer.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@29257 a1c6a512-1295-4272-9138-f99709370657

1 files changed, 2 insertions, 2 deletions

diff --git a/apps/buffering.c b/apps/buffering.c
index 8d41324190..e37b053881 100644
--- a/apps/buffering.c
+++ b/apps/buffering.c
@@ -254,7 +254,7 @@ static struct memory_handle *add_handle(size_t data_size, bool can_wrap,
     size_t shift;
     size_t new_widx;
     size_t len;
-    int overlap;
+    ssize_t overlap;
 
     if (num_handles >= BUF_MAX_HANDLES)
         return NULL;
@@ -296,7 +296,7 @@ static struct memory_handle *add_handle(size_t data_size, bool can_wrap,
 
     /* How much space are we short in the actual ring buffer? */
     overlap = ringbuf_add_cross(buf_widx, shift + len, buf_ridx);
-    if (overlap >= 0 && (alloc_all || (unsigned)overlap > data_size)) {
+    if (overlap >= 0 && (alloc_all || (size_t)overlap >= data_size)) {
         /* Not enough space for required allocations */
         mutex_unlock(&llist_mod_mutex);
         mutex_unlock(&llist_mutex);