summaryrefslogtreecommitdiff
path: root/apps/bookmark.c
diff options
context:
space:
mode:
authorWilliam Wilgus <wilgus.william@gmail.com>2022-11-14 11:32:34 -0500
committerWilliam Wilgus <me.theuser@yahoo.com>2022-11-14 23:56:16 -0500
commitf6c719d7ec71cc7771c46d3daa390924a3871ba3 (patch)
treee6209f23565db01809f75067247e667963092ff6 /apps/bookmark.c
parentb25a9d8f99b75570d18ea64602de7fe48da612d6 (diff)
downloadrockbox-f6c719d7ec71cc7771c46d3daa390924a3871ba3.tar.gz
rockbox-f6c719d7ec71cc7771c46d3daa390924a3871ba3.zip
replace strlcpy with strmemccpy
replace applicable calls to strlcpy with calls to strmemccpy which null terminates on truncation in theory the strmemccpy calls should be slightly faster since they don't traverse the rest of the source string on truncation but I seriously doubt there is too much of that going on in the code base Change-Id: Ia0251514e36a6242bbf3f03c5e0df123aba60ed2
Diffstat (limited to 'apps/bookmark.c')
-rw-r--r--apps/bookmark.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/apps/bookmark.c b/apps/bookmark.c
index d594c51320..0cc2807609 100644
--- a/apps/bookmark.c
+++ b/apps/bookmark.c
@@ -1075,7 +1075,7 @@ static bool parse_bookmark(const char *bookmark, const bool parse_filenames, con
1075 { 1075 {
1076 size_t len = (end == NULL) ? strlen(s) : (size_t) (end - s); 1076 size_t len = (end == NULL) ? strlen(s) : (size_t) (end - s);
1077 len = MIN(TEMP_BUF_SIZE - 1, len); 1077 len = MIN(TEMP_BUF_SIZE - 1, len);
1078 strlcpy(global_temp_buffer, s, len + 1); 1078 strmemccpy(global_temp_buffer, s, len + 1);
1079 1079
1080 if (end != NULL) 1080 if (end != NULL)
1081 { 1081 {
@@ -1089,7 +1089,7 @@ static bool parse_bookmark(const char *bookmark, const bool parse_filenames, con
1089 end++; 1089 end++;
1090 } 1090 }
1091 } 1091 }
1092 strlcpy(global_filename, end, MAX_PATH); 1092 strmemccpy(global_filename, end, MAX_PATH);
1093 } 1093 }
1094 } 1094 }
1095 1095