summaryrefslogtreecommitdiff
path: root/apps/bookmark.c
diff options
context:
space:
mode:
authorAidan MacDonald <amachronic@protonmail.com>2022-09-19 12:48:15 +0100
committerAidan MacDonald <amachronic@protonmail.com>2022-10-05 11:22:55 -0400
commitd5a081cbd1b871baf4e5d2c276fbabbc30c7994b (patch)
treeaac3c9377be8433ad15c4ca2a733d3a7c81aad97 /apps/bookmark.c
parentff378deb69951a53b866f3d3c6ee13022e520436 (diff)
downloadrockbox-d5a081cbd1b871baf4e5d2c276fbabbc30c7994b.tar.gz
rockbox-d5a081cbd1b871baf4e5d2c276fbabbc30c7994b.zip
gui: Remove "enum list_wrap" from list action functions
Removing the "list_wrap" argument is actually pretty easy. In practice, almost all lists are using LIST_WRAP_UNLESS_HELD behavior so we can make that the default. A couple of lists disable wraparound with LIST_WRAP_OFF; this is now achieved by setting the list "wraparound" flag to false when setting up the list. LIST_WRAP_ON was unused and is of questionable value, so it has been removed entirely. This makes list wraparound behavior a property of the list, controlled solely by the "wraparound" flag. The result is a simpler list API and implementation, without changing the behavior of any lists. Change-Id: Ib55d17519e6d92fc95ae17b84ab0aaf4233bcb5a
Diffstat (limited to 'apps/bookmark.c')
-rw-r--r--apps/bookmark.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/apps/bookmark.c b/apps/bookmark.c
index 70dbd8075d..d594c51320 100644
--- a/apps/bookmark.c
+++ b/apps/bookmark.c
@@ -793,8 +793,7 @@ static int select_bookmark(const char* bookmark_file_name, bool show_dont_resume
793 refresh = false; 793 refresh = false;
794 } 794 }
795 795
796 list_do_action(CONTEXT_BOOKMARKSCREEN, HZ / 2, 796 list_do_action(CONTEXT_BOOKMARKSCREEN, HZ / 2, &list, &action);
797 &list, &action, LIST_WRAP_UNLESS_HELD);
798 item = gui_synclist_get_sel_pos(&list) / 2; 797 item = gui_synclist_get_sel_pos(&list) / 2;
799 798
800 if (bookmarks->show_dont_resume) 799 if (bookmarks->show_dont_resume)