diff options
| author | Marcin Bukat <marcin.bukat@gmail.com> | 2012-01-24 13:05:25 +0100 |
|---|---|---|
| committer | Marcin Bukat <marcin.bukat@gmail.com> | 2012-01-24 13:05:25 +0100 |
| commit | fee6f80fb8bca110a03fc7693a17f4c5e4b798d2 (patch) | |
| tree | 5b6dc610f9d03e5c335da693309c92972046486e | |
| parent | dc85718bfda7c6009922a0c10ca9fe64f75faf2c (diff) | |
| download | rockbox-fee6f80fb8bca110a03fc7693a17f4c5e4b798d2.tar.gz rockbox-fee6f80fb8bca110a03fc7693a17f4c5e4b798d2.zip | |
Update CONTRIBUTING to reflect our switch to git on gerrit.
Fixes FS#12536
Change-Id: Iee4700ef01eb23c92a026df5074ffcf0257fe0ec
| -rw-r--r-- | docs/CONTRIBUTING | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/docs/CONTRIBUTING b/docs/CONTRIBUTING index 83f0aa655e..f31b1a8752 100644 --- a/docs/CONTRIBUTING +++ b/docs/CONTRIBUTING | |||
| @@ -1,5 +1,3 @@ | |||
| 1 | $Id$ | ||
| 2 | |||
| 3 | __________ __ ___. | 1 | __________ __ ___. |
| 4 | Open \______ \ ____ ____ | | _\_ |__ _______ ___ | 2 | Open \______ \ ____ ____ | | _\_ |__ _______ ___ |
| 5 | Source | _// _ \_/ ___\| |/ /| __ \ / _ \ \/ / | 3 | Source | _// _ \_/ ___\| |/ /| __ \ / _ \ \/ / |
| @@ -55,7 +53,7 @@ Braces for function declarations are put in a new line under the name, as in: | |||
| 55 | } | 53 | } |
| 56 | 54 | ||
| 57 | Always indent your code with four spaces. Don't use TAB characters, as that | 55 | Always indent your code with four spaces. Don't use TAB characters, as that |
| 58 | will mess up code display in CVS, printing, and a zillion other places. | 56 | will mess up code display, printing, and a zillion other places. |
| 59 | 57 | ||
| 60 | Keep lines below 80 columns length. Use whitespace and newlines to make the | 58 | Keep lines below 80 columns length. Use whitespace and newlines to make the |
| 61 | code easy to browse/read. | 59 | code easy to browse/read. |
| @@ -67,16 +65,18 @@ Use "unix style" line feeds: "LF" only. Do not use "CR+LF". | |||
| 67 | Use UTF-8 character set, but try to refrain from using any non-ascii | 65 | Use UTF-8 character set, but try to refrain from using any non-ascii |
| 68 | letters as they will only appear weird in some camps no matter what. | 66 | letters as they will only appear weird in some camps no matter what. |
| 69 | 67 | ||
| 70 | Patches | 68 | Contributing code |
| 71 | ------- | 69 | ------- |
| 72 | Create a patch using 'svn diff > mychanges.patch | 70 | We have a public code review system based on git, which is also how you can |
| 73 | Trim your patches so they only contain relevant changes. | 71 | check out the latest version of the Rockbox sources. |
| 72 | See http://www.rockbox.org/wiki/UsingGit for details on how to setup your | ||
| 73 | environment and how to upload a change you have made for review. | ||
| 74 | 74 | ||
| 75 | Submit your patch to the project via our patch tracker: | 75 | We'd prefer that you don't submit patches to the bug tracker any more, |
| 76 | http://www.rockbox.org/tracker/index.php?type=4 | 76 | as it's much harder to read and discuss them there. |
| 77 | 77 | ||
| 78 | Credits | 78 | Credits |
| 79 | ------- | 79 | ------- |
| 80 | We believe in crediting all contributors by name. Before committing a patch to | 80 | We believe in crediting all contributors by name. Before committing a patch to |
| 81 | SVN, we ask that you give us your full real name (no pseudonyms or nicknames) | 81 | Git, we ask that you give us your full real name (no pseudonyms or nicknames) |
| 82 | for adding to the credits list. | 82 | for adding to the credits list. |