summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChristian Soffke <christian.soffke@gmail.com>2022-11-27 23:37:26 +0100
committerChristian Soffke <christian.soffke@gmail.com>2023-01-07 14:53:36 +0100
commited95892a1f938956aca8d0b5b97434c9cbbbbe88 (patch)
tree10f9861e0b464a7550d562c34b6ce9010084b733
parent21ca64d7cda167d325d9b21ac25155eff13aac12 (diff)
downloadrockbox-ed95892a1f938956aca8d0b5b97434c9cbbbbe88.tar.gz
rockbox-ed95892a1f938956aca8d0b5b97434c9cbbbbe88.zip
Rename “Current Playlist” and “Playlist Catalogue” context menus
Use action-oriented and more descriptive titles "Add to Playlist..." instead of "Playlist Catalogue" - "Add to Existing Playlist" instead of "Add to Playlist" - "Add to New Playlist" (unchanged) - "Playing Next..." instead of "Current Playlist" In WPS context menu: - "Current Playlist" instead of "Playlist" Change-Id: I5cce9e317676537988682f46ac6b920598af3b9e
-rw-r--r--apps/lang/english.lang51
-rw-r--r--apps/onplay.c8
-rw-r--r--apps/playlist_viewer.c2
-rw-r--r--manual/configure_rockbox/playlist_options.tex6
-rw-r--r--manual/main_menu/main.tex2
-rw-r--r--manual/plugins/pictureflow.tex2
-rw-r--r--manual/rockbox_interface/browsing_and_playing.tex10
-rw-r--r--manual/rockbox_interface/wps.tex10
-rw-r--r--manual/working_with_playlists/main.tex38
9 files changed, 86 insertions, 43 deletions
diff --git a/apps/lang/english.lang b/apps/lang/english.lang
index d5f6ac3fa7..18842a3207 100644
--- a/apps/lang/english.lang
+++ b/apps/lang/english.lang
@@ -6452,16 +6452,16 @@
6452</phrase> 6452</phrase>
6453<phrase> 6453<phrase>
6454 id: LANG_CATALOG_ADD_TO 6454 id: LANG_CATALOG_ADD_TO
6455 desc: in onplay playlist catalogue submenu 6455 desc: deprecated
6456 user: core 6456 user: core
6457 <source> 6457 <source>
6458 *: "Add to Playlist" 6458 *: ""
6459 </source> 6459 </source>
6460 <dest> 6460 <dest>
6461 *: "Add to Playlist" 6461 *: ""
6462 </dest> 6462 </dest>
6463 <voice> 6463 <voice>
6464 *: "Add to Playlist" 6464 *: ""
6465 </voice> 6465 </voice>
6466</phrase> 6466</phrase>
6467<phrase> 6467<phrase>
@@ -16461,3 +16461,46 @@
16461 recording: "Recording Directory" 16461 recording: "Recording Directory"
16462 </voice> 16462 </voice>
16463</phrase> 16463</phrase>
16464<phrase>
16465 id: LANG_ADD_TO_PL
16466 desc: used in the onplay menu
16467 user: core
16468 <source>
16469 *: "Add to Playlist..."
16470 </source>
16471 <dest>
16472 *: "Add to Playlist..."
16473 </dest>
16474 <voice>
16475 *: "Add to Playlist..."
16476 </voice>
16477</phrase>
16478<phrase>
16479 id: LANG_ADD_TO_EXISTING_PL
16480 desc: used in the onplay menu
16481 user: core
16482 <source>
16483 *: "Add to Existing Playlist"
16484 </source>
16485 <dest>
16486 *: "Add to Existing Playlist"
16487 </dest>
16488 <voice>
16489 *: "Add to Existing Playlist"
16490 </voice>
16491</phrase>
16492<phrase>
16493 id: LANG_PLAYING_NEXT
16494 desc: used in the onplay menu
16495 user: core
16496 <source>
16497 *: "Playing Next..."
16498 </source>
16499 <dest>
16500 *: "Playing Next..."
16501 </dest>
16502 <voice>
16503 *: "Playing Next..."
16504 </voice>
16505</phrase>
16506
diff --git a/apps/onplay.c b/apps/onplay.c
index 842a328ee9..415cc05be8 100644
--- a/apps/onplay.c
+++ b/apps/onplay.c
@@ -491,7 +491,7 @@ MENUITEM_FUNCTION(reshuffle_item, 0, ID2P(LANG_SHUFFLE_PLAYLIST),
491 shuffle_playlist, NULL, Icon_Playlist); 491 shuffle_playlist, NULL, Icon_Playlist);
492MENUITEM_FUNCTION(playing_time_item, 0, ID2P(LANG_PLAYING_TIME), 492MENUITEM_FUNCTION(playing_time_item, 0, ID2P(LANG_PLAYING_TIME),
493 playing_time, NULL, Icon_Playlist); 493 playing_time, NULL, Icon_Playlist);
494MAKE_ONPLAYMENU( wps_playlist_menu, ID2P(LANG_PLAYLIST), 494MAKE_ONPLAYMENU( wps_playlist_menu, ID2P(LANG_CURRENT_PLAYLIST),
495 NULL, Icon_Playlist, 495 NULL, Icon_Playlist,
496 &wps_view_cur_playlist_item, &search_playlist_item, 496 &wps_view_cur_playlist_item, &search_playlist_item,
497 &playlist_save_item, &reshuffle_item, &playing_time_item 497 &playlist_save_item, &reshuffle_item, &playing_time_item
@@ -676,7 +676,7 @@ MENUITEM_FUNCTION_W_PARAM(replace_shuf_pl_item, 0, ID2P(LANG_PLAY_SHUFFLED),
676 add_to_playlist, &addtopl_replace_shuffled, 676 add_to_playlist, &addtopl_replace_shuffled,
677 treeplaylist_callback, Icon_Playlist); 677 treeplaylist_callback, Icon_Playlist);
678 678
679MAKE_ONPLAYMENU(tree_playlist_menu, ID2P(LANG_CURRENT_PLAYLIST), 679MAKE_ONPLAYMENU(tree_playlist_menu, ID2P(LANG_PLAYING_NEXT),
680 treeplaylist_callback, Icon_Playlist, 680 treeplaylist_callback, Icon_Playlist,
681 681
682 /* insert */ 682 /* insert */
@@ -801,11 +801,11 @@ static int cat_playlist_callback(int action,
801 const struct menu_item_ex *this_item, 801 const struct menu_item_ex *this_item,
802 struct gui_synclist *this_list); 802 struct gui_synclist *this_list);
803 803
804MENUITEM_FUNCTION(cat_add_to_list, 0, ID2P(LANG_CATALOG_ADD_TO), 804MENUITEM_FUNCTION(cat_add_to_list, 0, ID2P(LANG_ADD_TO_EXISTING_PL),
805 cat_add_to_a_playlist, NULL, Icon_Playlist); 805 cat_add_to_a_playlist, NULL, Icon_Playlist);
806MENUITEM_FUNCTION(cat_add_to_new, 0, ID2P(LANG_CATALOG_ADD_TO_NEW), 806MENUITEM_FUNCTION(cat_add_to_new, 0, ID2P(LANG_CATALOG_ADD_TO_NEW),
807 cat_add_to_a_new_playlist, NULL, Icon_Playlist); 807 cat_add_to_a_new_playlist, NULL, Icon_Playlist);
808MAKE_ONPLAYMENU(cat_playlist_menu, ID2P(LANG_CATALOG), 808MAKE_ONPLAYMENU(cat_playlist_menu, ID2P(LANG_ADD_TO_PL),
809 cat_playlist_callback, Icon_Playlist, 809 cat_playlist_callback, Icon_Playlist,
810 &cat_add_to_list, &cat_add_to_new); 810 &cat_add_to_list, &cat_add_to_new);
811 811
diff --git a/apps/playlist_viewer.c b/apps/playlist_viewer.c
index e9b57285cc..c9b027ea63 100644
--- a/apps/playlist_viewer.c
+++ b/apps/playlist_viewer.c
@@ -598,7 +598,7 @@ static enum pv_onplay_result onplay_menu(int index)
598 struct playlist_entry * current_track = 598 struct playlist_entry * current_track =
599 playlist_buffer_get_track(&viewer.buffer, index); 599 playlist_buffer_get_track(&viewer.buffer, index);
600 MENUITEM_STRINGLIST(menu_items, ID2P(LANG_PLAYLIST), NULL, 600 MENUITEM_STRINGLIST(menu_items, ID2P(LANG_PLAYLIST), NULL,
601 ID2P(LANG_CURRENT_PLAYLIST), ID2P(LANG_CATALOG), 601 ID2P(LANG_PLAYING_NEXT), ID2P(LANG_ADD_TO_PL),
602 ID2P(LANG_REMOVE), ID2P(LANG_MOVE), ID2P(LANG_MENU_SHOW_ID3_INFO), 602 ID2P(LANG_REMOVE), ID2P(LANG_MOVE), ID2P(LANG_MENU_SHOW_ID3_INFO),
603 ID2P(LANG_SHUFFLE), 603 ID2P(LANG_SHUFFLE),
604 ID2P(LANG_SAVE), 604 ID2P(LANG_SAVE),
diff --git a/manual/configure_rockbox/playlist_options.tex b/manual/configure_rockbox/playlist_options.tex
index b29842ceed..d881ba5b40 100644
--- a/manual/configure_rockbox/playlist_options.tex
+++ b/manual/configure_rockbox/playlist_options.tex
@@ -33,17 +33,17 @@ related to playlists.
33 33
34 \item[Keep Current Track When Replacing Playlist.] 34 \item[Keep Current Track When Replacing Playlist.]
35 If set to \setting{Yes}, then \setting{Play} and \setting{Play Shuffled} in 35 If set to \setting{Yes}, then \setting{Play} and \setting{Play Shuffled} in
36 the \setting{Current Playlist submenu} will allow the current track to finish 36 the \setting{Playing Next Submenu} will allow the current track to finish
37 playing before the new tracks play. If set to \setting{No}, the current 37 playing before the new tracks play. If set to \setting{No}, the current
38 track will be interrupted and new tracks will start playing immediately. 38 track will be interrupted and new tracks will start playing immediately.
39 39
40 \item[Show Shuffled Adding Options.] 40 \item[Show Shuffled Adding Options.]
41 If set to \setting{No}, Rockbox will not offer to add shuffled tracks 41 If set to \setting{No}, Rockbox will not offer to add shuffled tracks
42 in the \setting{Current Playlist submenu}. 42 in the \setting{Playing Next Submenu}.
43 43
44 \item[Show Queue Options.] 44 \item[Show Queue Options.]
45 If set to \setting{No}, Rockbox will not display the options to queue items in 45 If set to \setting{No}, Rockbox will not display the options to queue items in
46 the \setting{Current Playlist submenu}. 46 the \setting{Playing Next Submenu}.
47 If set to \setting{In Submenu}, Rockbox will move the options into a 47 If set to \setting{In Submenu}, Rockbox will move the options into a
48 separate submenu. 48 separate submenu.
49 49
diff --git a/manual/main_menu/main.tex b/manual/main_menu/main.tex
index 4aded9810b..34868ca759 100644
--- a/manual/main_menu/main.tex
+++ b/manual/main_menu/main.tex
@@ -160,7 +160,7 @@ The details of this menu are covered in
160 three ways. Playing a file in a directory causes all the files in it 160 three ways. Playing a file in a directory causes all the files in it
161 to be placed in a playlist. Playlists can be created manually by 161 to be placed in a playlist. Playlists can be created manually by
162 either using the \setting{Context Menu} (see \reference{ref:Contextmenu}) or using 162 either using the \setting{Context Menu} (see \reference{ref:Contextmenu}) or using
163 the \setting{Playlist} menu. Both automatically and manually created 163 the \setting{Current Playlist} menu. Both automatically and manually created
164 playlists can be edited using this menu. 164 playlists can be edited using this menu.
165 165
166\subsection{\label{ref:playlistcatalogue_contextmenu}The Playlist Catalogue Context Menu} 166\subsection{\label{ref:playlistcatalogue_contextmenu}The Playlist Catalogue Context Menu}
diff --git a/manual/plugins/pictureflow.tex b/manual/plugins/pictureflow.tex
index 0d249299d5..5b4e80e107 100644
--- a/manual/plugins/pictureflow.tex
+++ b/manual/plugins/pictureflow.tex
@@ -3,7 +3,7 @@
3PictureFlow is a visual browser for your albums. After you've selected something to play, 3PictureFlow is a visual browser for your albums. After you've selected something to play,
4PictureFlow will continue running by default, or can optionally show the WPS. Using the 4PictureFlow will continue running by default, or can optionally show the WPS. Using the
5context menu, albums or songs can be added to the dynamic playlist directly from 5context menu, albums or songs can be added to the dynamic playlist directly from
6PictureFlow (see \reference{ref:currentplaylist_submenu}). 6PictureFlow (see \reference{ref:playingnext_submenu}).
7 7
8 8
9\subsubsection{Sort Options} 9\subsubsection{Sort Options}
diff --git a/manual/rockbox_interface/browsing_and_playing.tex b/manual/rockbox_interface/browsing_and_playing.tex
index d97d227fe9..8460c12ec9 100644
--- a/manual/rockbox_interface/browsing_and_playing.tex
+++ b/manual/rockbox_interface/browsing_and_playing.tex
@@ -123,11 +123,11 @@ each option pertains both to files and directories):
123\begin{description} 123\begin{description}
124\item [View.] 124\item [View.]
125 Displays the contents of the selected playlist file. 125 Displays the contents of the selected playlist file.
126\item [Current Playlist.] 126\item [Playing Next...]
127 Enters the \setting{Current Playlist Submenu} (see \reference{ref:currentplaylist_submenu}). 127 Enters the \setting{Playing Next Submenu} (see \reference{ref:playingnext_submenu}).
128\item [Playlist Catalogue.] 128\item [Add to Playlist...]
129 Enters the \setting{Playlist Catalogue Submenu} (see 129 Enters the \setting{Add to Playlist Submenu} (see
130 \reference{ref:playlist_catalogue}). 130 \reference{ref:addtoplaylist_submenu}).
131\item [Rename.] 131\item [Rename.]
132 This function lets the user modify the name of a file or directory. 132 This function lets the user modify the name of a file or directory.
133\item [Cut.] 133\item [Cut.]
diff --git a/manual/rockbox_interface/wps.tex b/manual/rockbox_interface/wps.tex
index 7623f89146..45b3860b0e 100644
--- a/manual/rockbox_interface/wps.tex
+++ b/manual/rockbox_interface/wps.tex
@@ -179,8 +179,8 @@ several indicators.
179Like the context menu for the \setting{File Browser}, the \setting{WPS Context Menu} 179Like the context menu for the \setting{File Browser}, the \setting{WPS Context Menu}
180allows you quick access to some often used functions. 180allows you quick access to some often used functions.
181 181
182\subsubsection{Playlist} 182\subsubsection{Current Playlist}
183The \setting{Playlist} submenu allows you to view, save, search, reshuffle, 183The \setting{Current Playlist} submenu allows you to view, save, search, reshuffle,
184and display the play time of the current playlist. These and other operations 184and display the play time of the current playlist. These and other operations
185are detailed in \reference{ref:working_with_playlists}. To change settings for 185are detailed in \reference{ref:working_with_playlists}. To change settings for
186the \setting{Playlist Viewer} press \ActionStdContext{} while viewing the 186the \setting{Playlist Viewer} press \ActionStdContext{} while viewing the
@@ -198,12 +198,12 @@ menu, you can find the \setting{Playlist Viewer Settings}.
198 \end{description} 198 \end{description}
199 199
200 200
201\subsubsection{Playlist catalogue} 201\subsubsection{Add to Playlist...}
202 \begin{description} 202 \begin{description}
203 \item [Add to playlist.] Adds the currently playing file to a playlist. 203 \item [Add to Existing Playlist.] Adds the currently playing file to a playlist.
204 Select the playlist you want the file to be added to and it will get 204 Select the playlist you want the file to be added to and it will get
205 appended to that playlist. 205 appended to that playlist.
206 \item [Add to new playlist.] Similar to the previous entry this will 206 \item [Add to New Playlist.] Similar to the previous entry this will
207 add the currently playing track to a playlist. You need to enter a name 207 add the currently playing track to a playlist. You need to enter a name
208 for the new playlist first. 208 for the new playlist first.
209 \end{description} 209 \end{description}
diff --git a/manual/working_with_playlists/main.tex b/manual/working_with_playlists/main.tex
index 8571aac61c..c0e5615dea 100644
--- a/manual/working_with_playlists/main.tex
+++ b/manual/working_with_playlists/main.tex
@@ -17,7 +17,7 @@ playlists:
17 17
18\item[Dynamic playlist.] A dynamic playlist is a playlist that is created 18\item[Dynamic playlist.] A dynamic playlist is a playlist that is created
19 ``On the fly.'' Any time you insert or queue tracks using the 19 ``On the fly.'' Any time you insert or queue tracks using the
20 \setting{Current Playlist submenu} (see \reference{ref:currentplaylist_submenu}), you are 20 \setting{Playing Next Submenu} (see \reference{ref:playingnext_submenu}), you are
21 creating (or adding to) a dynamic playlist. 21 creating (or adding to) a dynamic playlist.
22 22
23\item[Insert.] In Rockbox, to \setting{Insert} an item into a playlist means 23\item[Insert.] In Rockbox, to \setting{Insert} an item into a playlist means
@@ -49,17 +49,17 @@ song.
49 playlist, see the section below on how to add music to a playlist.} 49 playlist, see the section below on how to add music to a playlist.}
50 50
51\subsubsection{By using the Play or Play Shuffled functions} 51\subsubsection{By using the Play or Play Shuffled functions}
52The \setting{Play} function as described in \ref{ref:currentplaylist_submenu} 52The \setting{Play} function as described in \ref{ref:playingnext_submenu}
53will replace the dynamic playlist with the selected tracks. The \setting{Play 53will replace the dynamic playlist with the selected tracks. The \setting{Play
54Shuffled} function is similar, except the selected tracks will be added to the 54Shuffled} function is similar, except the selected tracks will be added to the
55playlist in a random order. 55playlist in a random order.
56 56
57\subsubsection{\label{ref:playlist_catalogue}By using the Playlist catalogue} 57\subsubsection{\label{ref:addtoplaylist_submenu}By using the Add to Playlist submenu}
58The \setting{Playlist catalogue} makes it possible to modify and create 58The \setting{Add to Playlist submenu} makes it possible to modify and create
59playlists that are not currently playing. To do this select \setting{Playlist 59playlists that are not currently playing. To do this select \setting{Add to Playlist...}
60catalogue} in the \setting{Context Menu}. There you will have two choices, 60in the \setting{Context Menu}. There you will have two choices,
61\setting{Add to playlist} adds the selected track or directory to an existing 61\setting{Add to Existing Playlist} adds the selected track or directory to an existing
62playlist and \setting{Add to a new playlist} creates a new playlist containing 62playlist and \setting{Add to New Playlist} creates a new playlist containing
63the selected track or directory. 63the selected track or directory.
64 64
65\note{All playlists in the \setting{Playlist catalogue} are stored by default 65\note{All playlists in the \setting{Playlist catalogue} are stored by default
@@ -75,9 +75,9 @@ To create a playlist containing some or all of the music on your \dap{}, you can
75 75
76\subsection{Adding music to playlists} 76\subsection{Adding music to playlists}
77 77
78\subsubsection{\label{ref:currentplaylist_submenu}Adding music to a dynamic playlist} 78\subsubsection{\label{ref:playingnext_submenu}Adding music to a dynamic playlist}
79\screenshot{rockbox_interface/images/ss-playlist-menu}{The Current Playlist Submenu}{} 79\screenshot{rockbox_interface/images/ss-playlist-menu}{The Playing Next Submenu}{}
80The \setting{Current Playlist Submenu} is a submenu in the \setting{Context Menu} (see 80The \setting{Playing Next Submenu} is a submenu in the \setting{Context Menu} (see
81\reference{ref:Contextmenu}), it allows you to put tracks into a 81\reference{ref:Contextmenu}), it allows you to put tracks into a
82``dynamic playlist''. The place in which the newly 82``dynamic playlist''. The place in which the newly
83selected tracks are added to the playlist is determined by these 83selected tracks are added to the playlist is determined by these
@@ -133,10 +133,10 @@ The latter can also be put into its own submenu. Simply go to
133$\rightarrow$ \setting{Current Playlist} and select either \setting{Show Shuffled Adding Options} 133$\rightarrow$ \setting{Current Playlist} and select either \setting{Show Shuffled Adding Options}
134or \setting{Show Queue Options} to customize the displayed set of options.} 134or \setting{Show Queue Options} to customize the displayed set of options.}
135 135
136The \setting{Current Playlist Submenu} can be used to add either single tracks or 136The \setting{Playing Next Submenu} can be used to add either single tracks or
137entire directories to a playlist. If the \setting{Current Playlist Submenu} is 137entire directories to a playlist. If the \setting{Playing Next Submenu} is
138invoked on a single track, it will put only that track into the playlist. 138invoked on a single track, it will put only that track into the playlist.
139On the other hand, if the \setting{Current Playlist Submenu} is invoked on a 139On the other hand, if the \setting{Playing Next Submenu} is invoked on a
140directory, Rockbox adds all of the tracks in that directory to the 140directory, Rockbox adds all of the tracks in that directory to the
141playlist. 141playlist.
142 142
@@ -157,13 +157,13 @@ were before shutdown.
157 157
158\subsection{Modifying playlists} 158\subsection{Modifying playlists}
159\subsubsection{Reshuffling} 159\subsubsection{Reshuffling}
160Reshuffling the current playlist is easily done from the \setting{Playlist} 160Reshuffling the current playlist is easily done from the \setting{Current Playlist}
161sub menu in the WPS, just select \setting{Reshuffle}. 161sub menu in the WPS, just select \setting{Reshuffle}.
162 162
163\subsubsection{Moving and removing tracks} 163\subsubsection{Moving and removing tracks}
164To move or remove a track from the current playlist enter the 164To move or remove a track from the current playlist enter the
165\setting{Playlist Viewer} by selecting \setting{View Current Playlist} in the 165\setting{Playlist Viewer} by selecting \setting{View Current Playlist} in the
166\setting{Playlist} submenu in the WPS context menu or the \setting{Main Menu}. 166\setting{Current Playlist} submenu in the WPS context menu or the \setting{Main Menu}.
167Once in the \setting{Playlist Viewer} open the context menu on the track you 167Once in the \setting{Playlist Viewer} open the context menu on the track you
168want to move or remove. If you want to move the track, select \setting{Move} in 168want to move or remove. If you want to move the track, select \setting{Move} in
169the context menu and then move the blinking cursor to the place where you want 169the context menu and then move the blinking cursor to the place where you want
@@ -171,10 +171,10 @@ the track to be moved and confirm with \ActionStdOk. To remove a track, simply
171select \setting{Remove} in the context menu. 171select \setting{Remove} in the context menu.
172 172
173\subsection{Saving playlists} 173\subsection{Saving playlists}
174To save the current playlist either enter the \setting{Playlist} submenu 174To save the current playlist either enter the \setting{Current Playlist} submenu
175in the \setting{WPS Context Menu} (see \reference{sec:contextmenu}) and 175in the \setting{WPS Context Menu} (see \reference{sec:contextmenu}) and
176select \setting{Save Current Playlist} or enter the 176select \setting{Save Current Playlist} or enter the context menu for the
177\setting{Playlist Options} menu in the \setting{Main Menu} and select 177\setting{Playlist catalogue} in the \setting{Main Menu} and select
178\setting{Save Current Playlist}. 178\setting{Save Current Playlist}.
179Either method will bring you to the \setting{Virtual Keyboard} (see 179Either method will bring you to the \setting{Virtual Keyboard} (see
180\reference{sec:virtual_keyboard}), enter a filename for your playlist and 180\reference{sec:virtual_keyboard}), enter a filename for your playlist and