diff options
author | Solomon Peachy <pizza@shaftnet.org> | 2024-06-11 10:11:26 -0400 |
---|---|---|
committer | Solomon Peachy <pizza@shaftnet.org> | 2024-06-11 10:13:40 -0400 |
commit | ec23260fd1fc29f6de6705d08d2d1f182fd9891b (patch) | |
tree | e832b26acfe903dc90610566f1b465a09f3d2a42 | |
parent | 11c70c61643d2f40011cacc9907899e7aee878cd (diff) | |
download | rockbox-ec23260fd1fc29f6de6705d08d2d1f182fd9891b.tar.gz rockbox-ec23260fd1fc29f6de6705d08d2d1f182fd9891b.zip |
mikmod: Settings names should _NOT_ be i18n'd.
Regression was introduced back in 2019 in 2ebb8da275
Change-Id: I035e295b4e17e1f834059d1c6466562000749e54
-rw-r--r-- | apps/plugins/mikmod/mikmod.c | 16 | ||||
-rw-r--r-- | apps/plugins/text_viewer/tv_menu.c | 16 |
2 files changed, 16 insertions, 16 deletions
diff --git a/apps/plugins/mikmod/mikmod.c b/apps/plugins/mikmod/mikmod.c index bb0e2e04ab..30f8c2f079 100644 --- a/apps/plugins/mikmod/mikmod.c +++ b/apps/plugins/mikmod/mikmod.c | |||
@@ -588,48 +588,48 @@ static int settings_menu(void) | |||
588 | switch(selection) | 588 | switch(selection) |
589 | { | 589 | { |
590 | case 0: | 590 | case 0: |
591 | rb->set_int(rb->str(LANG_PANNING_SEPARATION), "", 1, | 591 | rb->set_int("Panning Separation", "", 1, |
592 | &(settings.pansep), | 592 | &(settings.pansep), |
593 | NULL, 8, 0, 128, NULL ); | 593 | NULL, 8, 0, 128, NULL ); |
594 | applysettings(); | 594 | applysettings(); |
595 | break; | 595 | break; |
596 | 596 | ||
597 | case 1: | 597 | case 1: |
598 | rb->set_int(rb->str(LANG_REVERBERATION), "", 1, | 598 | rb->set_int("Reverberation", "", 1, |
599 | &(settings.reverb), | 599 | &(settings.reverb), |
600 | NULL, 1, 0, 15, NULL ); | 600 | NULL, 1, 0, 15, NULL ); |
601 | applysettings(); | 601 | applysettings(); |
602 | break; | 602 | break; |
603 | 603 | ||
604 | case 2: | 604 | case 2: |
605 | rb->set_bool(rb->str(LANG_INTERPOLATION), &(settings.interp)); | 605 | rb->set_bool("Interpolation", &(settings.interp)); |
606 | applysettings(); | 606 | applysettings(); |
607 | break; | 607 | break; |
608 | 608 | ||
609 | case 3: | 609 | case 3: |
610 | rb->set_bool(rb->str(LANG_SWAP_CHANNELS), &(settings.reverse)); | 610 | rb->set_bool("Reverse Channels", &(settings.reverse)); |
611 | applysettings(); | 611 | applysettings(); |
612 | break; | 612 | break; |
613 | 613 | ||
614 | case 4: | 614 | case 4: |
615 | rb->set_bool(rb->str(LANG_MIKMOD_SURROUND), &(settings.surround)); | 615 | rb->set_bool("Surround", &(settings.surround)); |
616 | applysettings(); | 616 | applysettings(); |
617 | break; | 617 | break; |
618 | 618 | ||
619 | case 5: | 619 | case 5: |
620 | rb->set_bool(rb->str(LANG_MIKMOD_HQMIXER), &(settings.hqmixer)); | 620 | rb->set_bool("HQ Mixer", &(settings.hqmixer)); |
621 | applysettings(); | 621 | applysettings(); |
622 | break; | 622 | break; |
623 | 623 | ||
624 | case 6: | 624 | case 6: |
625 | rb->set_option(rb->str(LANG_MIKMOD_SAMPLERATE), &(settings.sample_rate), RB_INT, sr_names, | 625 | rb->set_option("Sample Rate", &(settings.sample_rate), RB_INT, sr_names, |
626 | HW_NUM_FREQ, NULL); | 626 | HW_NUM_FREQ, NULL); |
627 | applysettings(); | 627 | applysettings(); |
628 | break; | 628 | break; |
629 | 629 | ||
630 | #ifdef HAVE_ADJUSTABLE_CPU_FREQ | 630 | #ifdef HAVE_ADJUSTABLE_CPU_FREQ |
631 | case 7: | 631 | case 7: |
632 | rb->set_bool(rb->str(LANG_CPU_BOOST), &(settings.boost)); | 632 | rb->set_bool("CPU Boost", &(settings.boost)); |
633 | applysettings(); | 633 | applysettings(); |
634 | break; | 634 | break; |
635 | #endif | 635 | #endif |
diff --git a/apps/plugins/text_viewer/tv_menu.c b/apps/plugins/text_viewer/tv_menu.c index 15b684fe08..5b43a910c6 100644 --- a/apps/plugins/text_viewer/tv_menu.c +++ b/apps/plugins/text_viewer/tv_menu.c | |||
@@ -65,7 +65,7 @@ MAKE_MENU(horizontal_scroll_menu, "Horizontal", NULL, Icon_NOICON, // XXX i18n | |||
65 | 65 | ||
66 | static bool tv_vertical_scrollbar_setting(void) | 66 | static bool tv_vertical_scrollbar_setting(void) |
67 | { | 67 | { |
68 | return rb->set_bool("Vertical Scrollbar", &new_prefs.vertical_scrollbar); // XXX i18n | 68 | return rb->set_bool("Vertical Scrollbar", &new_prefs.vertical_scrollbar); |
69 | } | 69 | } |
70 | 70 | ||
71 | static bool tv_vertical_scroll_mode_setting(void) | 71 | static bool tv_vertical_scroll_mode_setting(void) |
@@ -75,18 +75,18 @@ static bool tv_vertical_scroll_mode_setting(void) | |||
75 | {"Scroll by Line", -1}, | 75 | {"Scroll by Line", -1}, |
76 | }; | 76 | }; |
77 | 77 | ||
78 | return rb->set_option("Scroll Mode", &new_prefs.vertical_scroll_mode, RB_INT, // XXX i18n | 78 | return rb->set_option("Scroll Mode", &new_prefs.vertical_scroll_mode, RB_INT, |
79 | names, 2, NULL); | 79 | names, 2, NULL); |
80 | } | 80 | } |
81 | 81 | ||
82 | static bool tv_overlap_page_mode_setting(void) | 82 | static bool tv_overlap_page_mode_setting(void) |
83 | { | 83 | { |
84 | return rb->set_bool("Overlap Pages", &new_prefs.overlap_page_mode); // XXX i18n | 84 | return rb->set_bool("Overlap Pages", &new_prefs.overlap_page_mode); |
85 | } | 85 | } |
86 | 86 | ||
87 | static bool tv_autoscroll_speed_setting(void) | 87 | static bool tv_autoscroll_speed_setting(void) |
88 | { | 88 | { |
89 | return rb->set_int("Auto-scroll Speed", "", UNIT_INT, // XXX i18n | 89 | return rb->set_int("Auto-scroll Speed", "", UNIT_INT, |
90 | &new_prefs.autoscroll_speed, NULL, 1, 1, 10, NULL); | 90 | &new_prefs.autoscroll_speed, NULL, 1, 1, 10, NULL); |
91 | } | 91 | } |
92 | 92 | ||
@@ -97,7 +97,7 @@ static bool tv_narrow_mode_setting(void) | |||
97 | {"Top/Bottom Page", -1}, | 97 | {"Top/Bottom Page", -1}, |
98 | }; | 98 | }; |
99 | 99 | ||
100 | return rb->set_option("Left/Right Key", &new_prefs.narrow_mode, RB_INT, // XXX i18n | 100 | return rb->set_option("Left/Right Key", &new_prefs.narrow_mode, RB_INT, |
101 | names, 2, NULL); | 101 | names, 2, NULL); |
102 | } | 102 | } |
103 | 103 | ||
@@ -165,12 +165,12 @@ static bool tv_line_mode_setting(void) | |||
165 | }; | 165 | }; |
166 | 166 | ||
167 | return rb->set_option("Line Mode", &new_prefs.line_mode, RB_INT, names, | 167 | return rb->set_option("Line Mode", &new_prefs.line_mode, RB_INT, names, |
168 | sizeof(names) / sizeof(names[0]), NULL); // XXX i18n | 168 | sizeof(names) / sizeof(names[0]), NULL); |
169 | } | 169 | } |
170 | 170 | ||
171 | static bool tv_windows_setting(void) | 171 | static bool tv_windows_setting(void) |
172 | { | 172 | { |
173 | return rb->set_int("Screens Per Page", "", UNIT_INT, // XXX i18n | 173 | return rb->set_int("Screens Per Page", "", UNIT_INT, |
174 | &new_prefs.windows, NULL, 1, 1, 5, NULL); | 174 | &new_prefs.windows, NULL, 1, 1, 5, NULL); |
175 | } | 175 | } |
176 | 176 | ||
@@ -182,7 +182,7 @@ static bool tv_alignment_setting(void) | |||
182 | }; | 182 | }; |
183 | 183 | ||
184 | return rb->set_option("Alignment", &new_prefs.alignment, RB_INT, | 184 | return rb->set_option("Alignment", &new_prefs.alignment, RB_INT, |
185 | names , 2, NULL); // XXX i18n | 185 | names , 2, NULL); |
186 | } | 186 | } |
187 | 187 | ||
188 | static bool tv_header_setting(void) | 188 | static bool tv_header_setting(void) |