diff options
author | Thomas Martitz <kugel@rockbox.org> | 2010-05-07 16:56:40 +0000 |
---|---|---|
committer | Thomas Martitz <kugel@rockbox.org> | 2010-05-07 16:56:40 +0000 |
commit | e919b5d5b929faf2af96ce0b36d8bc5b55236153 (patch) | |
tree | 85612a9614e2e98cdac5605a4a5e8c519270cc61 | |
parent | 9697b37d50194c839d930e8532ba9692278f81d4 (diff) | |
download | rockbox-e919b5d5b929faf2af96ce0b36d8bc5b55236153.tar.gz rockbox-e919b5d5b929faf2af96ce0b36d8bc5b55236153.zip |
Fix disastrous variable shadowing, change casts to unsigned in (cygwin doesn't like mode_t there, and unsigned int should be equally correct) and check the correct bitmask in sim_open().
Should repair filesystem accesses on the sim.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25881 a1c6a512-1295-4272-9138-f99709370657
-rw-r--r-- | apps/codecs.c | 2 | ||||
-rw-r--r-- | apps/plugin.c | 3 | ||||
-rw-r--r-- | apps/plugins/doom/rockdoom.c | 2 | ||||
-rw-r--r-- | uisimulator/common/io.c | 5 |
4 files changed, 6 insertions, 6 deletions
diff --git a/apps/codecs.c b/apps/codecs.c index 4d97baacbe..46d9223560 100644 --- a/apps/codecs.c +++ b/apps/codecs.c | |||
@@ -83,7 +83,7 @@ static int open(const char* pathname, int flags, ...) | |||
83 | { | 83 | { |
84 | va_list ap; | 84 | va_list ap; |
85 | va_start(ap, flags); | 85 | va_start(ap, flags); |
86 | fd = sim_open(pathname, flags, va_arg(ap, mode_t)); | 86 | fd = sim_open(pathname, flags, va_arg(ap, unsigned int)); |
87 | va_end(ap); | 87 | va_end(ap); |
88 | } | 88 | } |
89 | else | 89 | else |
diff --git a/apps/plugin.c b/apps/plugin.c index 8a32a159b4..e4480deed1 100644 --- a/apps/plugin.c +++ b/apps/plugin.c | |||
@@ -987,8 +987,7 @@ static int open_wrapper(const char* pathname, int flags, ...) | |||
987 | { | 987 | { |
988 | va_list ap; | 988 | va_list ap; |
989 | va_start(ap, flags); | 989 | va_start(ap, flags); |
990 | int fd; | 990 | fd = sim_open(pathname, flags, va_arg(ap, unsigned int)); |
991 | fd = sim_open(pathname, flags, va_arg(ap, mode_t)); | ||
992 | va_end(ap); | 991 | va_end(ap); |
993 | } | 992 | } |
994 | else | 993 | else |
diff --git a/apps/plugins/doom/rockdoom.c b/apps/plugins/doom/rockdoom.c index 1383a2b520..26afdd93db 100644 --- a/apps/plugins/doom/rockdoom.c +++ b/apps/plugins/doom/rockdoom.c | |||
@@ -72,7 +72,7 @@ int my_open(const char *file, int flags, ...) | |||
72 | { | 72 | { |
73 | va_list ap; | 73 | va_list ap; |
74 | va_start(ap, flags); | 74 | va_start(ap, flags); |
75 | filearray[fpoint]=rb->open(file, flags, va_arg(ap, mode_t)); | 75 | filearray[fpoint]=rb->open(file, flags, va_arg(ap, unsigned int)); |
76 | va_end(ap); | 76 | va_end(ap); |
77 | } | 77 | } |
78 | else | 78 | else |
diff --git a/uisimulator/common/io.c b/uisimulator/common/io.c index 937c710e06..cddb19c9a8 100644 --- a/uisimulator/common/io.c +++ b/uisimulator/common/io.c | |||
@@ -340,11 +340,12 @@ int sim_open(const char *name, int o, ...) | |||
340 | if (num_openfiles >= MAX_OPEN_FILES) | 340 | if (num_openfiles >= MAX_OPEN_FILES) |
341 | return -2; | 341 | return -2; |
342 | 342 | ||
343 | if (o & O_CREAT) | 343 | if (opts & O_CREAT) |
344 | { | 344 | { |
345 | va_list ap; | 345 | va_list ap; |
346 | va_start(ap, o); | 346 | va_start(ap, o); |
347 | ret = OPEN(get_sim_pathname(name), opts, va_arg(ap, mode_t)); | 347 | mode_t mode = va_arg(ap, unsigned int); |
348 | ret = OPEN(get_sim_pathname(name), opts, mode); | ||
348 | va_end(ap); | 349 | va_end(ap); |
349 | } | 350 | } |
350 | else | 351 | else |