summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMagnus Holmgren <magnushol@gmail.com>2007-08-25 10:56:22 +0000
committerMagnus Holmgren <magnushol@gmail.com>2007-08-25 10:56:22 +0000
commitcdfb22f9dfdbae2fdc6902f895fd89060abaa38b (patch)
tree64a7b49cd94e924ee0487cc4e8c5ffee818092e8
parent4e687327691e55282941e4493fca6d606281cdd0 (diff)
downloadrockbox-cdfb22f9dfdbae2fdc6902f895fd89060abaa38b.tar.gz
rockbox-cdfb22f9dfdbae2fdc6902f895fd89060abaa38b.zip
Remove some debug code. Remove some unnecessary checks.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14454 a1c6a512-1295-4272-9138-f99709370657
-rw-r--r--firmware/id3.c6
-rw-r--r--firmware/replaygain.c24
2 files changed, 8 insertions, 22 deletions
diff --git a/firmware/id3.c b/firmware/id3.c
index a0dda92eb9..d4a906fd3e 100644
--- a/firmware/id3.c
+++ b/firmware/id3.c
@@ -467,10 +467,8 @@ static int parserva2( struct mp3entry* entry, char* tag, int bufferpos )
467 gain = 0; 467 gain = 0;
468 } 468 }
469 469
470 if (gain) { 470 value_len = parse_replaygain_int(album, gain, peak * 2, entry,
471 value_len = parse_replaygain_int(album, gain, peak * 2, entry, 471 tag, sizeof(entry->id3v2buf) - (tag - entry->id3v2buf));
472 tag, sizeof(entry->id3v2buf) - (tag - entry->id3v2buf));
473 }
474 } 472 }
475 473
476 return tag - entry->id3v2buf + value_len; 474 return tag - entry->id3v2buf + value_len;
diff --git a/firmware/replaygain.c b/firmware/replaygain.c
index 07726f19da..05395d1efe 100644
--- a/firmware/replaygain.c
+++ b/firmware/replaygain.c
@@ -429,34 +429,22 @@ long parse_replaygain_int(bool album, long gain, long peak,
429 gain = convert_gain(gain * FP_ONE / 512); 429 gain = convert_gain(gain * FP_ONE / 512);
430 } 430 }
431 431
432 DEBUGF(" Album: %d\n", album);
433 DEBUGF(" Gain: %ld.%06ld\n", gain >> 24,
434 (long) (((long long) (abs(gain) & 0x00ffffff) * 1000000) / 0x01000000));
435 DEBUGF(" Peak: %ld.%06ld\n", peak >> 24,
436 (long) (((long long) (abs(peak) & 0x00ffffff) * 1000000) / 0x01000000));
437
438 if (album) 432 if (album)
439 { 433 {
440 if (!entry->album_gain) 434 entry->album_gain = gain;
441 { 435 entry->album_gain_string = buffer;
442 entry->album_gain = gain;
443 entry->album_gain_string = buffer;
444 }
445 436
446 if (!entry->album_peak) 437 if (peak)
447 { 438 {
448 entry->album_peak = peak; 439 entry->album_peak = peak;
449 } 440 }
450 } 441 }
451 else 442 else
452 { 443 {
453 if (!entry->track_gain) 444 entry->track_gain = gain;
454 { 445 entry->track_gain_string = buffer;
455 entry->track_gain = gain;
456 entry->track_gain_string = buffer;
457 }
458 446
459 if (!entry->track_peak) 447 if (peak)
460 { 448 {
461 entry->track_peak = peak; 449 entry->track_peak = peak;
462 } 450 }