summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBjörn Stenberg <bjorn@haxx.se>2002-12-18 14:57:45 +0000
committerBjörn Stenberg <bjorn@haxx.se>2002-12-18 14:57:45 +0000
commitc3fd67c6c90daf36349cf9bb1ebf6e8e640062a8 (patch)
treeb3d8583f32782ced81185c8dd56b56c0731771ef
parent34fa62b300bd7827b7924b1bc03b0987d3d09b82 (diff)
downloadrockbox-c3fd67c6c90daf36349cf9bb1ebf6e8e640062a8.tar.gz
rockbox-c3fd67c6c90daf36349cf9bb1ebf6e8e640062a8.zip
Killed a dozen global variables
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@3015 a1c6a512-1295-4272-9138-f99709370657
-rw-r--r--apps/recorder/peakmeter.c6
-rw-r--r--apps/recorder/recording.c2
-rw-r--r--apps/recorder/wormlet.c2
-rw-r--r--apps/status.c12
-rw-r--r--apps/status.h1
-rw-r--r--apps/tree.c4
-rw-r--r--firmware/kernel.c2
-rw-r--r--firmware/mpeg.c18
-rw-r--r--firmware/powermgmt.h2
9 files changed, 27 insertions, 22 deletions
diff --git a/apps/recorder/peakmeter.c b/apps/recorder/peakmeter.c
index 2e787ba982..a49a46a04b 100644
--- a/apps/recorder/peakmeter.c
+++ b/apps/recorder/peakmeter.c
@@ -49,9 +49,9 @@ static long peak_meter_clip_timeout_r;
49static int peak_meter_clip_hold; 49static int peak_meter_clip_hold;
50 50
51/* specifies the value range in peak volume values */ 51/* specifies the value range in peak volume values */
52unsigned short peak_meter_range_min; 52static unsigned short peak_meter_range_min;
53unsigned short peak_meter_range_max; 53static unsigned short peak_meter_range_max;
54unsigned short peak_meter_range; 54static unsigned short peak_meter_range;
55 55
56/* if set to true clip timeout is disabled */ 56/* if set to true clip timeout is disabled */
57static bool peak_meter_clip_eternal = false; 57static bool peak_meter_clip_eternal = false;
diff --git a/apps/recorder/recording.c b/apps/recorder/recording.c
index 3926382daa..22c8da2a33 100644
--- a/apps/recorder/recording.c
+++ b/apps/recorder/recording.c
@@ -104,7 +104,7 @@ char *fmt_gain(int snd, int val, char *str, int len)
104 return str; 104 return str;
105} 105}
106 106
107int cursor; 107static int cursor;
108 108
109void adjust_cursor(void) 109void adjust_cursor(void)
110{ 110{
diff --git a/apps/recorder/wormlet.c b/apps/recorder/wormlet.c
index f1654227ff..d6850dc039 100644
--- a/apps/recorder/wormlet.c
+++ b/apps/recorder/wormlet.c
@@ -64,7 +64,7 @@
64/** 64/**
65 * All the properties that a worm has. 65 * All the properties that a worm has.
66 */ 66 */
67struct worm { 67static struct worm {
68 /* The worm is stored in a ring of xy coordinates */ 68 /* The worm is stored in a ring of xy coordinates */
69 char x[MAX_WORM_SEGMENTS]; 69 char x[MAX_WORM_SEGMENTS];
70 char y[MAX_WORM_SEGMENTS]; 70 char y[MAX_WORM_SEGMENTS];
diff --git a/apps/status.c b/apps/status.c
index 20e672d8dc..91379bba2b 100644
--- a/apps/status.c
+++ b/apps/status.c
@@ -35,11 +35,13 @@
35 35
36static enum playmode current_mode = STATUS_STOP; 36static enum playmode current_mode = STATUS_STOP;
37 37
38long switch_tick; 38#if defined(HAVE_LCD_CHARCELLS) || defined(HAVE_CHARGE_CTRL)
39int battery_charge_step = 0; 39static long switch_tick;
40#ifdef HAVE_LCD_BITMAP 40static int battery_charge_step = 0;
41bool plug_state; 41#ifdef HAVE_CHARGE_CTRL
42bool battery_state; 42static bool plug_state;
43static bool battery_state;
44#endif
43#endif 45#endif
44 46
45void status_init(void) 47void status_init(void)
diff --git a/apps/status.h b/apps/status.h
index 74118f303b..8d0a492bf2 100644
--- a/apps/status.h
+++ b/apps/status.h
@@ -33,7 +33,6 @@ enum playmode
33void status_init(void); 33void status_init(void);
34void status_set_playmode(enum playmode mode); 34void status_set_playmode(enum playmode mode);
35#ifdef HAVE_LCD_BITMAP 35#ifdef HAVE_LCD_BITMAP
36extern bool statusbar_enabled;
37bool statusbar(bool state); 36bool statusbar(bool state);
38#endif 37#endif
39void status_draw(void); 38void status_draw(void);
diff --git a/apps/tree.c b/apps/tree.c
index 22cda58897..03de011255 100644
--- a/apps/tree.c
+++ b/apps/tree.c
@@ -56,8 +56,8 @@
56 56
57#define NAME_BUFFER_SIZE (AVERAGE_FILENAME_LENGTH * MAX_FILES_IN_DIR) 57#define NAME_BUFFER_SIZE (AVERAGE_FILENAME_LENGTH * MAX_FILES_IN_DIR)
58 58
59char name_buffer[NAME_BUFFER_SIZE]; 59static char name_buffer[NAME_BUFFER_SIZE];
60int name_buffer_length; 60static int name_buffer_length;
61struct entry { 61struct entry {
62 short attr; /* FAT attributes + file type flags */ 62 short attr; /* FAT attributes + file type flags */
63 char *name; 63 char *name;
diff --git a/firmware/kernel.c b/firmware/kernel.c
index 2b4b09f52b..4d2f519171 100644
--- a/firmware/kernel.c
+++ b/firmware/kernel.c
@@ -26,7 +26,7 @@
26 26
27long current_tick = 0; 27long current_tick = 0;
28 28
29void (*tick_funcs[MAX_NUM_TICK_TASKS])(void); 29static void (*tick_funcs[MAX_NUM_TICK_TASKS])(void);
30 30
31static void tick_start(unsigned int interval_in_ms); 31static void tick_start(unsigned int interval_in_ms);
32 32
diff --git a/firmware/mpeg.c b/firmware/mpeg.c
index 8d0cedd9f9..fb27a3b904 100644
--- a/firmware/mpeg.c
+++ b/firmware/mpeg.c
@@ -67,11 +67,13 @@ static int get_unswapped_space(void);
67#define MPEG_SAVE_DATA 102 67#define MPEG_SAVE_DATA 102
68#define MPEG_STOP_DONE 103 68#define MPEG_STOP_DONE 103
69 69
70enum 70#ifdef HAVE_MAS3587F
71static enum
71{ 72{
72 MPEG_DECODER, 73 MPEG_DECODER,
73 MPEG_ENCODER 74 MPEG_ENCODER
74} mpeg_mode; 75} mpeg_mode;
76#endif
75 77
76extern char* playlist_peek(int steps); 78extern char* playlist_peek(int steps);
77extern int playlist_next(int steps); 79extern int playlist_next(int steps);
@@ -457,9 +459,9 @@ extern unsigned char mp3buf[];
457extern unsigned char mp3end[]; 459extern unsigned char mp3end[];
458 460
459static int mp3buflen; 461static int mp3buflen;
460int mp3buf_write; 462static int mp3buf_write;
461static int mp3buf_swapwrite; 463static int mp3buf_swapwrite;
462int mp3buf_read; 464static int mp3buf_read;
463 465
464static int last_dma_chunk_size; 466static int last_dma_chunk_size;
465 467
@@ -691,10 +693,12 @@ static void stop_dma(void)
691} 693}
692 694
693#ifdef HAVE_MAS3587F 695#ifdef HAVE_MAS3587F
694long timing_info_index = 0; 696#ifdef DEBUG
695long timing_info[1024]; 697static long timing_info_index = 0;
696bool inverted_pr; 698static long timing_info[1024];
697unsigned long num_rec_bytes; 699#endif
700static bool inverted_pr;
701static unsigned long num_rec_bytes;
698 702
699void drain_dma_buffer(void) 703void drain_dma_buffer(void)
700{ 704{
diff --git a/firmware/powermgmt.h b/firmware/powermgmt.h
index ea6319c02e..b9686119c0 100644
--- a/firmware/powermgmt.h
+++ b/firmware/powermgmt.h
@@ -70,7 +70,6 @@ extern int charge_state; /* tells what the charger is doing (for info di
70#define CURRENT_CHARGING 300 /* charging current */ 70#define CURRENT_CHARGING 300 /* charging current */
71 71
72extern unsigned short power_history[POWER_HISTORY_LEN]; 72extern unsigned short power_history[POWER_HISTORY_LEN];
73void set_battery_capacity(int capacity); /* set local battery capacity value */
74 73
75/* Start up power management thread */ 74/* Start up power management thread */
76void power_init(void); 75void power_init(void);
@@ -85,6 +84,7 @@ int battery_time(void); /* minutes */
85bool battery_level_safe(void); 84bool battery_level_safe(void);
86 85
87void set_poweroff_timeout(int timeout); 86void set_poweroff_timeout(int timeout);
87void set_battery_capacity(int capacity); /* set local battery capacity value */
88 88
89void set_sleep_timer(int seconds); 89void set_sleep_timer(int seconds);
90int get_sleep_timer(void); 90int get_sleep_timer(void);