Fix logdisk

The code was broken in a subtle but crucial way: storage idle
callbacks are oneshot so after the first flush everything would
stay in the buffer forever and would never be written to the disk
thus resulting into many events being lost. This changed correctly
registers the idle callback each time the buffer is not empty.
Note that the idle storage code checks if a callback
has is in the queue already so we don't register twice.

Change-Id: Ifdf331d4b757e05b8a6902bf5926cbc7689f5109

2 files changed, 4 insertions, 10 deletions

diff --git a/apps/main.c b/apps/main.c
index 7333f7dc8d..7dc61754d3 100644
--- a/apps/main.c
+++ b/apps/main.c
@@ -489,10 +489,6 @@ static void init(void)
 #endif
 #endif
 
-#ifdef ROCKBOX_HAS_LOGDISKF
-    init_logdiskf();
-#endif
-
 #if CONFIG_RTC
     rtc_init();
 #endif
diff --git a/firmware/logf.c b/firmware/logf.c
index e135b0b27f..fadfc9bb13 100644
--- a/firmware/logf.c
+++ b/firmware/logf.c
@@ -273,6 +273,8 @@ static int logdiskf_push(void *userp, unsigned char c)
     return true;
 }
 
+static void flush_buffer(void* data);
+
 void _logdiskf(const char* file, const char level, const char *fmt, ...)
 {
 
@@ -296,9 +298,9 @@ void _logdiskf(const char* file, const char level, const char *fmt, ...)
 
     vuprintf(logdiskf_push, NULL, fmt, ap);
     va_end(ap);
-
-
+    register_storage_idle_func(flush_buffer);
 }
+
 static void flush_buffer(void* data)
 {
     (void)data;
@@ -316,8 +318,4 @@ static void flush_buffer(void* data)
     logdiskfindex = 0;
 }
 
-void init_logdiskf()
-{
-    register_storage_idle_func(flush_buffer);
-}
 #endif