diff options
author | Solomon Peachy <pizza@shaftnet.org> | 2020-05-18 16:49:26 -0400 |
---|---|---|
committer | Solomon Peachy <pizza@shaftnet.org> | 2020-05-18 22:51:01 +0200 |
commit | 9e674c712f9cfa6342291add796979124b0740c7 (patch) | |
tree | fbc2f6b5a1236eea97be1f495f59c995affc64ba | |
parent | 2da6766f7598a7d77ac362caded2bba1a4d20318 (diff) | |
download | rockbox-9e674c712f9cfa6342291add796979124b0740c7.tar.gz rockbox-9e674c712f9cfa6342291add796979124b0740c7.zip |
FS#13195: rocker: Improved root menu keymap (Howard Richardson)
This patch addresses a keymapping anomaly on the Rocker. Currently the
Power button when pressed inside a sub-menu will return you to the root
of the menu. However when pressed again it returns you to the sub-menu
you were in previously. This is at odds with how other ports work and
makes it difficult to return to the WPS without manually selecting it on
the root menu.
This patch copies the behaviour of the home button on the Sansa Clip+.
Pressing it once will exit a sub-menu and bring you back to the root
menu. Pressing it again takes you to the WPS. No functionality is lost
or covered up by making this reassignment.
Change-Id: I17789457d49b087a2b4c75f4490ec722d9479a9b
-rw-r--r-- | apps/keymaps/keymap-agptekrocker.c | 7 | ||||
-rw-r--r-- | docs/CREDITS | 1 |
2 files changed, 8 insertions, 0 deletions
diff --git a/apps/keymaps/keymap-agptekrocker.c b/apps/keymaps/keymap-agptekrocker.c index aa7c687ce4..1c13239bea 100644 --- a/apps/keymaps/keymap-agptekrocker.c +++ b/apps/keymaps/keymap-agptekrocker.c | |||
@@ -54,6 +54,12 @@ static const struct button_mapping button_context_standard[] = { | |||
54 | }; /* button_context_standard */ | 54 | }; /* button_context_standard */ |
55 | 55 | ||
56 | 56 | ||
57 | static const struct button_mapping button_context_mainmenu[] = { | ||
58 | { ACTION_TREE_WPS, BUTTON_POWER, BUTTON_NONE }, | ||
59 | |||
60 | LAST_ITEM_IN_LIST__NEXTLIST(CONTEXT_TREE), | ||
61 | }; /* button_context_mainmenu as with sansa clip mapping - "back" button returns you to WPS */ | ||
62 | |||
57 | static const struct button_mapping button_context_wps[] = { | 63 | static const struct button_mapping button_context_wps[] = { |
58 | /* { ACTION_WPS_BROWSE, BUTTON_UP|BUTTON_REPEAT, BUTTON_UP }, */ | 64 | /* { ACTION_WPS_BROWSE, BUTTON_UP|BUTTON_REPEAT, BUTTON_UP }, */ |
59 | { ACTION_WPS_PLAY, BUTTON_SELECT|BUTTON_REL, BUTTON_SELECT }, | 65 | { ACTION_WPS_PLAY, BUTTON_SELECT|BUTTON_REL, BUTTON_SELECT }, |
@@ -223,6 +229,7 @@ const struct button_mapping* get_context_mapping(int context) | |||
223 | return button_context_wps; | 229 | return button_context_wps; |
224 | 230 | ||
225 | case CONTEXT_MAINMENU: | 231 | case CONTEXT_MAINMENU: |
232 | return button_context_mainmenu; | ||
226 | case CONTEXT_TREE: | 233 | case CONTEXT_TREE: |
227 | case CONTEXT_LIST: | 234 | case CONTEXT_LIST: |
228 | return button_context_list; | 235 | return button_context_list; |
diff --git a/docs/CREDITS b/docs/CREDITS index 5bf01f50db..fd598a4127 100644 --- a/docs/CREDITS +++ b/docs/CREDITS | |||
@@ -690,6 +690,7 @@ Johannes König | |||
690 | Alexander Drammen | 690 | Alexander Drammen |
691 | Kei Miyamoto | 691 | Kei Miyamoto |
692 | James D. Smith | 692 | James D. Smith |
693 | Howard Richardson | ||
693 | 694 | ||
694 | The libmad team | 695 | The libmad team |
695 | The wavpack team | 696 | The wavpack team |