summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBrandon Low <lostlogic@rockbox.org>2006-04-22 21:31:07 +0000
committerBrandon Low <lostlogic@rockbox.org>2006-04-22 21:31:07 +0000
commit83ce56846a65ce14b2410d07da8fcc4790e0b6f7 (patch)
treecd7ae17eabbf77f44eab0ce528cdc5e15784e5b6
parent41c0aacc352e677627b2a0c6ffc99ec61dbcef99 (diff)
downloadrockbox-83ce56846a65ce14b2410d07da8fcc4790e0b6f7.tar.gz
rockbox-83ce56846a65ce14b2410d07da8fcc4790e0b6f7.zip
Remove an unneeded define, add a todo
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@9765 a1c6a512-1295-4272-9138-f99709370657
-rw-r--r--apps/codecs/mpa.c3
-rw-r--r--apps/playback.c1
2 files changed, 2 insertions, 2 deletions
diff --git a/apps/codecs/mpa.c b/apps/codecs/mpa.c
index bbfbb574e6..fa5dab6543 100644
--- a/apps/codecs/mpa.c
+++ b/apps/codecs/mpa.c
@@ -34,8 +34,6 @@ struct mad_synth synth IBSS_ATTR;
34void abort(void) { 34void abort(void) {
35} 35}
36 36
37/* These extra 8 bytes fake-added to each read make mad decode the last frame */
38#define MAD_BUFFER_GUARD 8
39#define INPUT_CHUNK_SIZE 8192 37#define INPUT_CHUNK_SIZE 8192
40 38
41mad_fixed_t mad_frame_overlap[2][32][18] IBSS_ATTR; 39mad_fixed_t mad_frame_overlap[2][32][18] IBSS_ATTR;
@@ -183,6 +181,7 @@ enum codec_status codec_start(struct codec_api *api)
183 inputbuffer = ci->request_buffer(&size, INPUT_CHUNK_SIZE); 181 inputbuffer = ci->request_buffer(&size, INPUT_CHUNK_SIZE);
184 if (size == 0 || inputbuffer == NULL) 182 if (size == 0 || inputbuffer == NULL)
185 break; 183 break;
184 /* size + MAD_BUFFER_GUARD to help mad decode the last frame */
186 mad_stream_buffer(&stream, (unsigned char *)inputbuffer, 185 mad_stream_buffer(&stream, (unsigned char *)inputbuffer,
187 size + MAD_BUFFER_GUARD); 186 size + MAD_BUFFER_GUARD);
188 } 187 }
diff --git a/apps/playback.c b/apps/playback.c
index 0bc0fb3b70..33d0d7a747 100644
--- a/apps/playback.c
+++ b/apps/playback.c
@@ -20,6 +20,7 @@
20/* TODO: Fast codecs seem to cause badness on track skipping (stop, old audio, 20/* TODO: Fast codecs seem to cause badness on track skipping (stop, old audio,
21 * then new audio). Investigate the CFL_FLUSH mode used for all track skips */ 21 * then new audio). Investigate the CFL_FLUSH mode used for all track skips */
22/* TODO: Check for a possibly broken codepath on a rapid skip, stop event */ 22/* TODO: Check for a possibly broken codepath on a rapid skip, stop event */
23/* TODO: same in reverse ^^ */
23/* TODO: Can use the track changed callback to detect end of track and seek 24/* TODO: Can use the track changed callback to detect end of track and seek
24 * in the previous track until this happens */ 25 * in the previous track until this happens */
25/* Design: we have prev_ti already, have a conditional for what type of seek 26/* Design: we have prev_ti already, have a conditional for what type of seek