diff options
author | Christian Soffke <christian.soffke@gmail.com> | 2021-11-21 11:34:03 +0100 |
---|---|---|
committer | Solomon Peachy <pizza@shaftnet.org> | 2021-12-02 17:37:49 -0500 |
commit | 8325b59f3b2b7eee3d4e7476371e3bd3019fe612 (patch) | |
tree | 15abfd4fed2f6d70336c3a9da4edeceb0624aa43 | |
parent | 2ee4f50fa6f727f114e16e63dc9ed6e12d0720e5 (diff) | |
download | rockbox-8325b59f3b2b7eee3d4e7476371e3bd3019fe612.tar.gz rockbox-8325b59f3b2b7eee3d4e7476371e3bd3019fe612.zip |
PictureFlow: (grayscale) invert ‘Added to Playlist’ message
Feels less interruptive this way, since the background doesn't
suddenly switch from dark to light.
Also moved message to separate function and added missing
lcd_update() after clearing display.
Change-Id: Id196554b42fa4de16a6b23136d27358159b746b6
-rw-r--r-- | apps/plugins/pictureflow/pictureflow.c | 32 |
1 files changed, 19 insertions, 13 deletions
diff --git a/apps/plugins/pictureflow/pictureflow.c b/apps/plugins/pictureflow/pictureflow.c index c2fe178167..aba9443120 100644 --- a/apps/plugins/pictureflow/pictureflow.c +++ b/apps/plugins/pictureflow/pictureflow.c | |||
@@ -3623,6 +3623,24 @@ static void draw_album_text(void) | |||
3623 | } | 3623 | } |
3624 | 3624 | ||
3625 | /** | 3625 | /** |
3626 | Display an info message when items have been added to playlist | ||
3627 | */ | ||
3628 | static void rb_splash_added_to_playlist(void) | ||
3629 | { | ||
3630 | #ifdef USEGSLIB | ||
3631 | grey_show(false); | ||
3632 | rb->lcd_set_background(N_BRIGHT(0)); | ||
3633 | rb->lcd_set_foreground(N_BRIGHT(255)); | ||
3634 | rb->lcd_clear_display(); | ||
3635 | rb->lcd_update(); | ||
3636 | #endif | ||
3637 | rb->splash(HZ*2, ID2P(LANG_ADDED_TO_PLAYLIST)); | ||
3638 | #ifdef USEGSLIB | ||
3639 | grey_show(true); | ||
3640 | #endif | ||
3641 | } | ||
3642 | |||
3643 | /** | ||
3626 | Display an error message and wait for input. | 3644 | Display an error message and wait for input. |
3627 | */ | 3645 | */ |
3628 | static void error_wait(const char *message) | 3646 | static void error_wait(const char *message) |
@@ -3946,19 +3964,7 @@ static int pictureflow_main(void) | |||
3946 | PLAYLIST_INSERT_LAST, false, true); | 3964 | PLAYLIST_INSERT_LAST, false, true); |
3947 | rb->playlist_sync(NULL); | 3965 | rb->playlist_sync(NULL); |
3948 | } | 3966 | } |
3949 | #ifdef USEGSLIB | 3967 | rb_splash_added_to_playlist(); |
3950 | /* | ||
3951 | calling splash() without switching off the grayscale overlay | ||
3952 | beforehand, will lead to image corruption and a crash | ||
3953 | in testing on device (iPod 4G,iPod mini) | ||
3954 | */ | ||
3955 | grey_show(false); | ||
3956 | rb->lcd_clear_display(); | ||
3957 | #endif | ||
3958 | rb->splash(HZ*2, ID2P(LANG_ADDED_TO_PLAYLIST)); | ||
3959 | #ifdef USEGSLIB | ||
3960 | grey_show(true); | ||
3961 | #endif | ||
3962 | } | 3968 | } |
3963 | break; | 3969 | break; |
3964 | #endif | 3970 | #endif |