diff options
author | Nils Wallménius <nils@rockbox.org> | 2007-10-02 09:08:08 +0000 |
---|---|---|
committer | Nils Wallménius <nils@rockbox.org> | 2007-10-02 09:08:08 +0000 |
commit | 605949d48239551f721f5e8110d5f1001a2b2623 (patch) | |
tree | b809945dea13749f8d1881ba50611f6dbfed71d8 | |
parent | 6d0ee558e86beece998bfa032c06b091cf723355 (diff) | |
download | rockbox-605949d48239551f721f5e8110d5f1001a2b2623.tar.gz rockbox-605949d48239551f721f5e8110d5f1001a2b2623.zip |
Hide symbols by default on 64 bit sim buildsto avoid clashing, fixes crashing on track change with the same codec, crashing in calculator and text display in midiplay
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@14953 a1c6a512-1295-4272-9138-f99709370657
-rw-r--r-- | apps/codecs.h | 3 | ||||
-rw-r--r-- | apps/plugin.h | 3 | ||||
-rwxr-xr-x | tools/configure | 5 |
3 files changed, 8 insertions, 3 deletions
diff --git a/apps/codecs.h b/apps/codecs.h index 50bc36baa2..a59a791d42 100644 --- a/apps/codecs.h +++ b/apps/codecs.h | |||
@@ -267,7 +267,8 @@ extern unsigned char plugin_end_addr[]; | |||
267 | #else /* def SIMULATOR */ | 267 | #else /* def SIMULATOR */ |
268 | /* decoders */ | 268 | /* decoders */ |
269 | #define CODEC_HEADER \ | 269 | #define CODEC_HEADER \ |
270 | const struct codec_header __header = { \ | 270 | const struct codec_header __header \ |
271 | __attribute__((visibility("default"))) = { \ | ||
271 | CODEC_MAGIC, TARGET_ID, CODEC_API_VERSION, \ | 272 | CODEC_MAGIC, TARGET_ID, CODEC_API_VERSION, \ |
272 | NULL, NULL, codec_start }; | 273 | NULL, NULL, codec_start }; |
273 | /* encoders */ | 274 | /* encoders */ |
diff --git a/apps/plugin.h b/apps/plugin.h index 5f868e5654..5f98f951e6 100644 --- a/apps/plugin.h +++ b/apps/plugin.h | |||
@@ -655,7 +655,8 @@ extern unsigned char plugin_end_addr[]; | |||
655 | plugin_start_addr, plugin_end_addr, plugin_start }; | 655 | plugin_start_addr, plugin_end_addr, plugin_start }; |
656 | #else /* SIMULATOR */ | 656 | #else /* SIMULATOR */ |
657 | #define PLUGIN_HEADER \ | 657 | #define PLUGIN_HEADER \ |
658 | const struct plugin_header __header = { \ | 658 | const struct plugin_header __header \ |
659 | __attribute__((visibility("default"))) = { \ | ||
659 | PLUGIN_MAGIC, TARGET_ID, PLUGIN_API_VERSION, \ | 660 | PLUGIN_MAGIC, TARGET_ID, PLUGIN_API_VERSION, \ |
660 | NULL, NULL, plugin_start }; | 661 | NULL, NULL, plugin_start }; |
661 | #endif /* SIMULATOR */ | 662 | #endif /* SIMULATOR */ |
diff --git a/tools/configure b/tools/configure index ec0fa02aca..5311c64f55 100755 --- a/tools/configure +++ b/tools/configure | |||
@@ -134,7 +134,10 @@ simcc () { | |||
134 | esac | 134 | esac |
135 | 135 | ||
136 | if [ "`uname -m`" = "x86_64" ] || [ "`uname -m`" = "amd64" ]; then | 136 | if [ "`uname -m`" = "x86_64" ] || [ "`uname -m`" = "amd64" ]; then |
137 | GCCOPTS="$GCCOPTS -fPIC" # needed to make shared objects link | 137 | # fPIC is needed to make shared objects link |
138 | # setting visibility to hidden is necessary to avoid strange crashes | ||
139 | # due to symbol clashing | ||
140 | GCCOPTS="$GCCOPTS -fPIC -fvisibility=hidden" | ||
138 | fi | 141 | fi |
139 | 142 | ||
140 | GCCOPTS="$GCCOPTS -I\$(SIMDIR)" | 143 | GCCOPTS="$GCCOPTS -I\$(SIMDIR)" |