summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorOsborne Jacobs <ozziejacks@gmail.com>2012-03-03 00:15:31 -0500
committerJonathan Gordon <rockbox@jdgordon.info>2012-03-13 03:17:12 +0100
commit595427c095df06ad0560dfbaa96710034a51d9c8 (patch)
treedbaaa2a0bd37400896a02823cb5b8ed21007140a
parent47e30b8cdccb0849ee2d7c4c74769fc2d1fa8919 (diff)
downloadrockbox-595427c095df06ad0560dfbaa96710034a51d9c8.tar.gz
rockbox-595427c095df06ad0560dfbaa96710034a51d9c8.zip
Add new actions to %Tp (Touchscreen areas)
Add the following actions to %Tp: createbookmark create a new bookmark from the wps listbookmarks list bookmarks from the wps trackinfo show track info from the wps My main motivation was to allow bookmarking and jumping around audio books from the wps on touch enabled targets. You can do it now through the context menu but it requires 4 screen presses instead of 1. Change-Id: I1fa1bf0064dfd22b897eca7c56acc1ce8956f14c Reviewed-on: http://gerrit.rockbox.org/171 Reviewed-by: Jonathan Gordon <rockbox@jdgordon.info>
-rw-r--r--apps/action.h2
-rw-r--r--apps/gui/skin_engine/skin_parser.c5
-rw-r--r--apps/gui/wps.c15
-rw-r--r--manual/appendix/wps_tags.tex17
4 files changed, 31 insertions, 8 deletions
diff --git a/apps/action.h b/apps/action.h
index e46e4a64b2..508d9a31a6 100644
--- a/apps/action.h
+++ b/apps/action.h
@@ -129,6 +129,8 @@ enum {
129 ACTION_WPS_QUICKSCREEN,/* optional */ 129 ACTION_WPS_QUICKSCREEN,/* optional */
130 ACTION_WPS_MENU, /*this should be the same as ACTION_STD_MENU */ 130 ACTION_WPS_MENU, /*this should be the same as ACTION_STD_MENU */
131 ACTION_WPS_VIEW_PLAYLIST, 131 ACTION_WPS_VIEW_PLAYLIST,
132 ACTION_WPS_LIST_BOOKMARKS,/* optional */
133 ACTION_WPS_CREATE_BOOKMARK,/* optional */
132 ACTION_WPS_REC, 134 ACTION_WPS_REC,
133#if 0 135#if 0
134 ACTION_WPSAB_SINGLE, /* This needs to be #defined in 136 ACTION_WPSAB_SINGLE, /* This needs to be #defined in
diff --git a/apps/gui/skin_engine/skin_parser.c b/apps/gui/skin_engine/skin_parser.c
index 4e4b9d14d2..2d9d7cd807 100644
--- a/apps/gui/skin_engine/skin_parser.c
+++ b/apps/gui/skin_engine/skin_parser.c
@@ -1287,7 +1287,10 @@ static const struct touchaction touchactions[] = {
1287 {"browse", ACTION_WPS_BROWSE }, 1287 {"browse", ACTION_WPS_BROWSE },
1288 {"play", ACTION_WPS_PLAY }, {"stop", ACTION_WPS_STOP }, 1288 {"play", ACTION_WPS_PLAY }, {"stop", ACTION_WPS_STOP },
1289 {"shuffle", ACTION_TOUCH_SHUFFLE }, {"repmode", ACTION_TOUCH_REPMODE }, 1289 {"shuffle", ACTION_TOUCH_SHUFFLE }, {"repmode", ACTION_TOUCH_REPMODE },
1290 {"pitch", ACTION_WPS_PITCHSCREEN}, {"playlist", ACTION_WPS_VIEW_PLAYLIST }, 1290 {"pitch", ACTION_WPS_PITCHSCREEN}, {"trackinfo", ACTION_WPS_ID3SCREEN },
1291 {"playlist", ACTION_WPS_VIEW_PLAYLIST },
1292 {"listbookmarks", ACTION_WPS_LIST_BOOKMARKS },
1293 {"createbookmark", ACTION_WPS_CREATE_BOOKMARK },
1291 1294
1292#if CONFIG_TUNER 1295#if CONFIG_TUNER
1293 /* FM screen actions */ 1296 /* FM screen actions */
diff --git a/apps/gui/wps.c b/apps/gui/wps.c
index 1e48e80202..313ac2cd76 100644
--- a/apps/gui/wps.c
+++ b/apps/gui/wps.c
@@ -1042,6 +1042,21 @@ long gui_wps_show(void)
1042 exit = true; 1042 exit = true;
1043 break; 1043 break;
1044 1044
1045 case ACTION_WPS_LIST_BOOKMARKS:
1046 gwps_leave_wps();
1047 if (bookmark_load_menu() == BOOKMARK_USB_CONNECTED)
1048 {
1049 return GO_TO_ROOT;
1050 }
1051 restore = true;
1052 break;
1053
1054 case ACTION_WPS_CREATE_BOOKMARK:
1055 gwps_leave_wps();
1056 bookmark_create_menu();
1057 restore = true;
1058 break;
1059
1045 case ACTION_WPS_ID3SCREEN: 1060 case ACTION_WPS_ID3SCREEN:
1046 { 1061 {
1047 gwps_leave_wps(); 1062 gwps_leave_wps();
diff --git a/manual/appendix/wps_tags.tex b/manual/appendix/wps_tags.tex
index f68bd70f37..7a37f899a5 100644
--- a/manual/appendix/wps_tags.tex
+++ b/manual/appendix/wps_tags.tex
@@ -657,19 +657,22 @@ display cycling round the defined sublines. See
657 \item[wps\_next] -- Next track. 657 \item[wps\_next] -- Next track.
658 \item[ffwd] -- Seek forwards in the track. 658 \item[ffwd] -- Seek forwards in the track.
659 \item[rwd] -- Seek backwards in the track. 659 \item[rwd] -- Seek backwards in the track.
660 \item[menu] -- Go to the main menu. 660 \item[progressbar] -- Seek to the appropriate position in the track based on the touch.
661 \item[browse] -- Go back to the file browser or database.
662 \item[shuffle] -- Toggle shuffle mode. 661 \item[shuffle] -- Toggle shuffle mode.
663 \item[repmode] -- Cycle through the repeat modes. 662 \item[repmode] -- Cycle through the repeat modes.
664 \item[quickscreen] -- Go to the quickscreen.
665 \item[contextmenu] -- Open the context menu.
666 \item[playlist] -- Go to the playlist viewer.
667 \item[progressbar] -- Seek to the appropriate position in the track based on the touch.
668 \item[volume] -- Set the volume to the appropriate level based on the touch. 663 \item[volume] -- Set the volume to the appropriate level based on the touch.
669 \item[pitch] -- Open the pitchscreen.
670 \item[voldown] -- Decrease the volume by one step. 664 \item[voldown] -- Decrease the volume by one step.
671 \item[volup] -- Increase the volume by one step. 665 \item[volup] -- Increase the volume by one step.
672 \item[mute] -- Un/Mute playback. 666 \item[mute] -- Un/Mute playback.
667 \item[createbookmark] -- Create a bookmark in the currently-playing track.
668 \item[menu] -- Go to the main menu.
669 \item[browse] -- Go back to the file browser or database.
670 \item[quickscreen] -- Go to the quickscreen.
671 \item[contextmenu] -- Open the context menu.
672 \item[playlist] -- Go to the playlist viewer.
673 \item[listbookmarks] -- List the bookmarks for the currently-playing directory or playlist.
674 \item[trackinfo] -- Open the track info viewer.
675 \item[pitch] -- Open the pitchscreen.
673 \item[setting\_inc] -- Increment the subsequently specified setting (e.g 676 \item[setting\_inc] -- Increment the subsequently specified setting (e.g
674 \config{\%T(0,0, setting\_inc, volume)} increases the volume by one step). 677 \config{\%T(0,0, setting\_inc, volume)} increases the volume by one step).
675 \item[setting\_dec] -- Decrement the subsequently specified setting (e.g 678 \item[setting\_dec] -- Decrement the subsequently specified setting (e.g