diff options
author | Amaury Pouly <amaury.pouly@gmail.com> | 2014-09-18 13:01:35 +0200 |
---|---|---|
committer | Amaury Pouly <amaury.pouly@gmail.com> | 2014-09-19 10:58:16 +0200 |
commit | 57d6db6ff597c692e3d35a4ddffc86189268f8f6 (patch) | |
tree | c387056aeb040f88c6a675d97ae935114e101f4d | |
parent | 79c5a07b4d067c00fa5ad4decf1d269bae2cb72f (diff) | |
download | rockbox-57d6db6ff597c692e3d35a4ddffc86189268f8f6.tar.gz rockbox-57d6db6ff597c692e3d35a4ddffc86189268f8f6.zip |
qeditor: fix UI to update register/analyser view on each tree/list click
Change-Id: Idaceb7ffaf33c2184a43353dd9d7dee20ac807a9
Reviewed-on: http://gerrit.rockbox.org/972
Reviewed-by: Amaury Pouly <amaury.pouly@gmail.com>
-rw-r--r-- | utils/regtools/qeditor/regtab.cpp | 22 | ||||
-rw-r--r-- | utils/regtools/qeditor/regtab.h | 2 |
2 files changed, 5 insertions, 19 deletions
diff --git a/utils/regtools/qeditor/regtab.cpp b/utils/regtools/qeditor/regtab.cpp index 9292248c61..132308e8ff 100644 --- a/utils/regtools/qeditor/regtab.cpp +++ b/utils/regtools/qeditor/regtab.cpp | |||
@@ -143,12 +143,12 @@ RegTab::RegTab(Backend *backend, QWidget *parent) | |||
143 | connect(m_soc_selector, SIGNAL(currentIndexChanged(int)), | 143 | connect(m_soc_selector, SIGNAL(currentIndexChanged(int)), |
144 | this, SLOT(OnSocChanged(int))); | 144 | this, SLOT(OnSocChanged(int))); |
145 | connect(m_backend, SIGNAL(OnSocListChanged()), this, SLOT(OnSocListChanged())); | 145 | connect(m_backend, SIGNAL(OnSocListChanged()), this, SLOT(OnSocListChanged())); |
146 | connect(m_reg_tree, SIGNAL(currentItemChanged(QTreeWidgetItem*, QTreeWidgetItem*)), | 146 | connect(m_reg_tree, SIGNAL(itemClicked(QTreeWidgetItem*, int)), |
147 | this, SLOT(OnRegItemChanged(QTreeWidgetItem*, QTreeWidgetItem*))); | 147 | this, SLOT(OnRegItemClicked(QTreeWidgetItem*, int))); |
148 | connect(m_data_soc_label, SIGNAL(linkActivated(const QString&)), this, | 148 | connect(m_data_soc_label, SIGNAL(linkActivated(const QString&)), this, |
149 | SLOT(OnDataSocActivated(const QString&))); | 149 | SLOT(OnDataSocActivated(const QString&))); |
150 | connect(m_analysers_list, SIGNAL(currentItemChanged(QListWidgetItem *, QListWidgetItem *)), | 150 | connect(m_analysers_list, SIGNAL(itemClicked(QListWidgetItem *)), |
151 | this, SLOT(OnAnalyserChanged(QListWidgetItem *, QListWidgetItem *))); | 151 | this, SLOT(OnAnalyserClicked(QListWidgetItem *))); |
152 | connect(m_backend_selector, SIGNAL(OnSelect(IoBackend *)), | 152 | connect(m_backend_selector, SIGNAL(OnSelect(IoBackend *)), |
153 | this, SLOT(OnBackendSelect(IoBackend *))); | 153 | this, SLOT(OnBackendSelect(IoBackend *))); |
154 | connect(m_readonly_check, SIGNAL(clicked(bool)), this, SLOT(OnReadOnlyClicked(bool))); | 154 | connect(m_readonly_check, SIGNAL(clicked(bool)), this, SLOT(OnReadOnlyClicked(bool))); |
@@ -209,13 +209,7 @@ void RegTab::SetReadOnlyIndicator() | |||
209 | 209 | ||
210 | void RegTab::OnDataChanged() | 210 | void RegTab::OnDataChanged() |
211 | { | 211 | { |
212 | OnRegItemChanged(m_reg_tree->currentItem(), m_reg_tree->currentItem()); | 212 | OnRegItemClicked(m_reg_tree->currentItem(), 0); |
213 | } | ||
214 | |||
215 | void RegTab::OnRegItemChanged(QTreeWidgetItem *current, QTreeWidgetItem *previous) | ||
216 | { | ||
217 | Q_UNUSED(previous); | ||
218 | OnRegItemClicked(current, 0); | ||
219 | } | 213 | } |
220 | 214 | ||
221 | void RegTab::OnRegItemClicked(QTreeWidgetItem *current, int col) | 215 | void RegTab::OnRegItemClicked(QTreeWidgetItem *current, int col) |
@@ -240,12 +234,6 @@ void RegTab::OnRegItemClicked(QTreeWidgetItem *current, int col) | |||
240 | } | 234 | } |
241 | } | 235 | } |
242 | 236 | ||
243 | void RegTab::OnAnalyserChanged(QListWidgetItem *current, QListWidgetItem *previous) | ||
244 | { | ||
245 | Q_UNUSED(previous); | ||
246 | OnAnalyserClicked(current); | ||
247 | } | ||
248 | |||
249 | void RegTab::OnAnalyserClicked(QListWidgetItem *current) | 237 | void RegTab::OnAnalyserClicked(QListWidgetItem *current) |
250 | { | 238 | { |
251 | if(current == 0) | 239 | if(current == 0) |
diff --git a/utils/regtools/qeditor/regtab.h b/utils/regtools/qeditor/regtab.h index 781deff41c..f48b72e683 100644 --- a/utils/regtools/qeditor/regtab.h +++ b/utils/regtools/qeditor/regtab.h | |||
@@ -79,12 +79,10 @@ private slots: | |||
79 | void SetReadOnlyIndicator(); | 79 | void SetReadOnlyIndicator(); |
80 | void OnSocChanged(int index); | 80 | void OnSocChanged(int index); |
81 | void OnSocListChanged(); | 81 | void OnSocListChanged(); |
82 | void OnRegItemChanged(QTreeWidgetItem *current, QTreeWidgetItem *previous); | ||
83 | void OnRegItemClicked(QTreeWidgetItem *clicked, int col); | 82 | void OnRegItemClicked(QTreeWidgetItem *clicked, int col); |
84 | void OnBackendSelect(IoBackend *backend); | 83 | void OnBackendSelect(IoBackend *backend); |
85 | void OnDataChanged(); | 84 | void OnDataChanged(); |
86 | void OnDataSocActivated(const QString&); | 85 | void OnDataSocActivated(const QString&); |
87 | void OnAnalyserChanged(QListWidgetItem *current, QListWidgetItem *previous); | ||
88 | void OnAnalyserClicked(QListWidgetItem *clicked); | 86 | void OnAnalyserClicked(QListWidgetItem *clicked); |
89 | void OnReadOnlyClicked(bool); | 87 | void OnReadOnlyClicked(bool); |
90 | void OnDumpRegs(bool); | 88 | void OnDumpRegs(bool); |