diff options
author | Bertrik Sikken <bertrik@sikken.nl> | 2010-01-18 21:20:36 +0000 |
---|---|---|
committer | Bertrik Sikken <bertrik@sikken.nl> | 2010-01-18 21:20:36 +0000 |
commit | 552835ebe2b47feb5914060df1df681758a21edf (patch) | |
tree | b30da06add820de7a5b1b5a9a7d36b4ed89ef878 | |
parent | 99a7cdc46cc58e5965e939be7a31d377d73f0ffd (diff) | |
download | rockbox-552835ebe2b47feb5914060df1df681758a21edf.tar.gz rockbox-552835ebe2b47feb5914060df1df681758a21edf.zip |
Add a missing #include, make a function static, make touchpad_set_buttonlight implementation and declaration consistent
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24281 a1c6a512-1295-4272-9138-f99709370657
-rw-r--r-- | apps/gui/skin_engine/skin_parser.c | 2 | ||||
-rw-r--r-- | apps/usb_keymaps.c | 1 | ||||
-rw-r--r-- | firmware/drivers/synaptics-mep.c | 23 | ||||
-rw-r--r-- | firmware/export/synaptics-mep.h | 2 |
4 files changed, 15 insertions, 13 deletions
diff --git a/apps/gui/skin_engine/skin_parser.c b/apps/gui/skin_engine/skin_parser.c index 9157ffaa3c..c70a9759ee 100644 --- a/apps/gui/skin_engine/skin_parser.c +++ b/apps/gui/skin_engine/skin_parser.c | |||
@@ -145,7 +145,7 @@ static int parse_setting_and_lang(const char *wps_bufptr, | |||
145 | struct wps_token *token, struct wps_data *wps_data); | 145 | struct wps_token *token, struct wps_data *wps_data); |
146 | 146 | ||
147 | 147 | ||
148 | int parse_languagedirection(const char *wps_bufptr, | 148 | static int parse_languagedirection(const char *wps_bufptr, |
149 | struct wps_token *token, struct wps_data *wps_data) | 149 | struct wps_token *token, struct wps_data *wps_data) |
150 | { | 150 | { |
151 | (void)wps_bufptr; | 151 | (void)wps_bufptr; |
diff --git a/apps/usb_keymaps.c b/apps/usb_keymaps.c index 61e6f64d6b..ade2891720 100644 --- a/apps/usb_keymaps.c +++ b/apps/usb_keymaps.c | |||
@@ -25,6 +25,7 @@ | |||
25 | #include "lang.h" | 25 | #include "lang.h" |
26 | #include "misc.h" | 26 | #include "misc.h" |
27 | #include "usbstack/usb_hid.h" | 27 | #include "usbstack/usb_hid.h" |
28 | #include "usb_keymaps.h" | ||
28 | /*#define LOGF_ENABLE*/ | 29 | /*#define LOGF_ENABLE*/ |
29 | #include "logf.h" | 30 | #include "logf.h" |
30 | 31 | ||
diff --git a/firmware/drivers/synaptics-mep.c b/firmware/drivers/synaptics-mep.c index 9c12351f42..87b78d09c1 100644 --- a/firmware/drivers/synaptics-mep.c +++ b/firmware/drivers/synaptics-mep.c | |||
@@ -25,6 +25,7 @@ | |||
25 | #include "system.h" | 25 | #include "system.h" |
26 | #include "kernel.h" | 26 | #include "kernel.h" |
27 | #include "button-target.h" | 27 | #include "button-target.h" |
28 | #include "synaptics-mep.h" | ||
28 | 29 | ||
29 | /*#define LOGF_ENABLE*/ | 30 | /*#define LOGF_ENABLE*/ |
30 | #include "logf.h" | 31 | #include "logf.h" |
@@ -579,7 +580,7 @@ int touchpad_read_device(char *data, int len) | |||
579 | return val; | 580 | return val; |
580 | } | 581 | } |
581 | 582 | ||
582 | int touchpad_set_buttonlights(int led_mask, char brightness) | 583 | int touchpad_set_buttonlights(unsigned int led_mask, char brightness) |
583 | { | 584 | { |
584 | char data[6]; | 585 | char data[6]; |
585 | int val = 0; | 586 | int val = 0; |
@@ -589,22 +590,22 @@ int touchpad_set_buttonlights(int led_mask, char brightness) | |||
589 | syn_enable_int(false); | 590 | syn_enable_int(false); |
590 | #if defined(PBELL_VIBE500) | 591 | #if defined(PBELL_VIBE500) |
591 | /* In Packard Bell Vibe 500 leds are controlled through the MEP parameters 0x62 - 0x63 | 592 | /* In Packard Bell Vibe 500 leds are controlled through the MEP parameters 0x62 - 0x63 |
592 | There is no 0x31 order - grup led control */ | 593 | There is no 0x31 order - grup led control */ |
593 | 594 | ||
594 | /* Make sure we have a led_block_mask = 0 - obtained experimentally */ | 595 | /* Make sure we have a led_block_mask = 0 - obtained experimentally */ |
595 | data[0] = 0x03; /* header - addr:0,global:0,control:0,len:3 */ | 596 | data[0] = 0x03; /* header - addr:0,global:0,control:0,len:3 */ |
596 | data[1] = 0x63; /* parameter nr: 0x23 (-0x40) - led_block_mask */ | 597 | data[1] = 0x63; /* parameter nr: 0x23 (-0x40) - led_block_mask */ |
597 | data[2] = 0x00; /* par_hi = 0 */ | 598 | data[2] = 0x00; /* par_hi = 0 */ |
598 | data[3] = 0x00; /* par_lo = 0 */ | 599 | data[3] = 0x00; /* par_lo = 0 */ |
599 | syn_send(data,4); | 600 | syn_send(data,4); |
600 | val = syn_read(data, 1); /* get the simple ACK = 0x18 */ | 601 | val = syn_read(data, 1); /* get the simple ACK = 0x18 */ |
601 | 602 | ||
602 | /* Turn on/off the lights (there is no brightness control) - obtained experimentally */ | 603 | /* Turn on/off the lights (there is no brightness control) - obtained experimentally */ |
603 | data[0] = 0x03; /* header - addr:0,global:0,control:0,len:3 */ | 604 | data[0] = 0x03; /* header - addr:0,global:0,control:0,len:3 */ |
604 | data[1] = 0x62; /* parameter nr: 0x22 (-0x40) - led_mask */ | 605 | data[1] = 0x62; /* parameter nr: 0x22 (-0x40) - led_mask */ |
605 | data[2] = 0x00; /* par_hi = 0 */ | 606 | data[2] = 0x00; /* par_hi = 0 */ |
606 | data[3] = (led_mask & 0x0f) | (brightness&0); /* par_lo = led_mask */ | 607 | data[3] = (led_mask & 0x0f) | (brightness&0); /* par_lo = led_mask */ |
607 | syn_send(data,4); | 608 | syn_send(data,4); |
608 | val = syn_read(data, 1); /* get the simple ACK = 0x18 */ | 609 | val = syn_read(data, 1); /* get the simple ACK = 0x18 */ |
609 | #else | 610 | #else |
610 | /* turn on all touchpad leds */ | 611 | /* turn on all touchpad leds */ |
diff --git a/firmware/export/synaptics-mep.h b/firmware/export/synaptics-mep.h index df6ddaac11..225891383e 100644 --- a/firmware/export/synaptics-mep.h +++ b/firmware/export/synaptics-mep.h | |||
@@ -23,6 +23,6 @@ | |||
23 | 23 | ||
24 | int touchpad_init(void); | 24 | int touchpad_init(void); |
25 | int touchpad_read_device(char *data, int len); | 25 | int touchpad_read_device(char *data, int len); |
26 | int touchpad_set_buttonlights(char led_mask, char brightness); | 26 | int touchpad_set_buttonlights(unsigned int led_mask, char brightness); |
27 | 27 | ||
28 | #endif | 28 | #endif |