diff options
author | Aidan MacDonald <amachronic@protonmail.com> | 2022-11-30 01:27:00 +0000 |
---|---|---|
committer | Aidan MacDonald <amachronic@protonmail.com> | 2022-12-01 14:24:51 -0500 |
commit | 528dd0b03d27fa82b97e3fe785969b90f32cdeff (patch) | |
tree | 3a13327bb0c678e31d26853ec2ae46925809756f | |
parent | fb0757b9132db40b4436215a0ecdb1537dc93907 (diff) | |
download | rockbox-528dd0b03d27fa82b97e3fe785969b90f32cdeff.tar.gz rockbox-528dd0b03d27fa82b97e3fe785969b90f32cdeff.zip |
settings: Remove redundant lang_id check for F_PADTITLE settings
All the F_PADTITLE settings use a lang string so it's safe to
assume the title (which is usually from the setting's lang_id)
is ok. Not like it's very useful or safe to show the cfg_vals,
anyway...
Change-Id: I0bf710e1b2a5a7bcdfe9e4370f48a2f25e8dddf0
-rw-r--r-- | apps/menu.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/apps/menu.c b/apps/menu.c index 1b2c21cef7..eb3adcc037 100644 --- a/apps/menu.c +++ b/apps/menu.c | |||
@@ -333,10 +333,7 @@ void do_setting_screen(const struct settings_list *setting, const char * title, | |||
333 | if (setting->flags&F_PADTITLE) | 333 | if (setting->flags&F_PADTITLE) |
334 | { | 334 | { |
335 | int i = 0, len; | 335 | int i = 0, len; |
336 | if (setting->lang_id == -1) | 336 | title = P2STR((unsigned char*)title); |
337 | title = (char*)setting->cfg_vals; | ||
338 | else | ||
339 | title = P2STR((unsigned char*)title); | ||
340 | len = strlen(title); | 337 | len = strlen(title); |
341 | while (i < MAX_PATH-1) | 338 | while (i < MAX_PATH-1) |
342 | { | 339 | { |