summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMarcoen Hirschberg <marcoen@gmail.com>2005-12-07 08:37:14 +0000
committerMarcoen Hirschberg <marcoen@gmail.com>2005-12-07 08:37:14 +0000
commit46b726eaab751669726895f6f5fa30095b062e80 (patch)
tree7c38335f79ef97f89b0f7a852a2959453b301bbd
parent1184ae9de74c24a2c4d2704bc2f68ec2972602f3 (diff)
downloadrockbox-46b726eaab751669726895f6f5fa30095b062e80.tar.gz
rockbox-46b726eaab751669726895f6f5fa30095b062e80.zip
several small fixes sugested by different people (FireFly, Lear, Takka)
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@8184 a1c6a512-1295-4272-9138-f99709370657
-rw-r--r--apps/bookmark.c4
-rw-r--r--firmware/common/unicode.c2
-rw-r--r--firmware/mpeg.c7
-rwxr-xr-xtools/buildzip.pl4
4 files changed, 5 insertions, 12 deletions
diff --git a/apps/bookmark.c b/apps/bookmark.c
index 8980e4fc26..ce82f77742 100644
--- a/apps/bookmark.c
+++ b/apps/bookmark.c
@@ -207,9 +207,7 @@ bool bookmark_autobookmark(void)
207 return write_bookmark(false); 207 return write_bookmark(false);
208 } 208 }
209#ifdef HAVE_LCD_BITMAP 209#ifdef HAVE_LCD_BITMAP
210 unsigned char *lines[]={str(LANG_AUTO_BOOKMARK_QUERY), 210 unsigned char *lines[]={str(LANG_AUTO_BOOKMARK_QUERY);
211 str(LANG_CONFIRM_WITH_PLAY_RECORDER),
212 str(LANG_CANCEL_WITH_ANY_RECORDER)};
213 struct text_message message={(char **)lines, 3}; 211 struct text_message message={(char **)lines, 3};
214#else 212#else
215 unsigned char *lines[]={str(LANG_AUTO_BOOKMARK_QUERY), 213 unsigned char *lines[]={str(LANG_AUTO_BOOKMARK_QUERY),
diff --git a/firmware/common/unicode.c b/firmware/common/unicode.c
index 4e1b78f9e1..e2e2dc2f3a 100644
--- a/firmware/common/unicode.c
+++ b/firmware/common/unicode.c
@@ -92,7 +92,7 @@ unsigned char* utf8encode(unsigned long ucs, unsigned char *utf8)
92 int tail = 0; 92 int tail = 0;
93 93
94 if (ucs > 0x7F) 94 if (ucs > 0x7F)
95 while (ucs >> (6*tail + 2)) 95 while (ucs >> (5*tail + 6))
96 tail++; 96 tail++;
97 97
98 *utf8++ = (ucs >> (6*tail)) | utf8comp[tail]; 98 *utf8++ = (ucs >> (6*tail)) | utf8comp[tail];
diff --git a/firmware/mpeg.c b/firmware/mpeg.c
index b5f1ef83c7..5b1a543f2d 100644
--- a/firmware/mpeg.c
+++ b/firmware/mpeg.c
@@ -920,10 +920,9 @@ static struct trackdata *add_track_to_tag_list(const char *filename)
920 track->mempos = audiobuf_write; 920 track->mempos = audiobuf_write;
921 track->id3.elapsed = 0; 921 track->id3.elapsed = 0;
922#ifdef HAVE_LCD_BITMAP 922#ifdef HAVE_LCD_BITMAP
923 int w, h; 923 lcd_getstringsize(track->id3.title, NULL, NULL);
924 lcd_getstringsize(track->id3.title, &w, &h); 924 lcd_getstringsize(track->id3.artist, NULL, NULL);
925 lcd_getstringsize(track->id3.artist, &w, &h); 925 lcd_getstringsize(track->id3.album, NULL, NULL);
926 lcd_getstringsize(track->id3.album, &w, &h);
927#endif 926#endif
928 927
929 track_write_idx = (track_write_idx+1) & MAX_TRACK_ENTRIES_MASK; 928 track_write_idx = (track_write_idx+1) & MAX_TRACK_ENTRIES_MASK;
diff --git a/tools/buildzip.pl b/tools/buildzip.pl
index 57ffbdf749..1942071565 100755
--- a/tools/buildzip.pl
+++ b/tools/buildzip.pl
@@ -78,10 +78,6 @@ sub buildzip {
78 # no codec was copied, remove directory again 78 # no codec was copied, remove directory again
79 rmdir(".rockbox/codecs"); 79 rmdir(".rockbox/codecs");
80 80
81 system("$ROOT/tools/codepages");
82 my $c = 'find . -name "*.cp" ! -empty -exec mv {} .rockbox/codepages/ \; >/dev/null 2>&1';
83 print `$c`;
84
85 } 81 }
86 82
87 83