summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorThomas Martitz <kugel@rockbox.org>2010-10-31 12:00:03 +0000
committerThomas Martitz <kugel@rockbox.org>2010-10-31 12:00:03 +0000
commit2d05d2f9daebd7559c9dd05f4784e5f677b6dbbe (patch)
treeebaaf5d90d0ed0914e279df369ff263f1bd90d18
parentcc758e42b9456c6093636647ae1dd8f64e639ff0 (diff)
downloadrockbox-2d05d2f9daebd7559c9dd05f4784e5f677b6dbbe.tar.gz
rockbox-2d05d2f9daebd7559c9dd05f4784e5f677b6dbbe.zip
Clean up r28408 coding style a bit to follow our guidelines with regard to
brace placement, tabs and 80 char line width. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28410 a1c6a512-1295-4272-9138-f99709370657
-rw-r--r--android/src/org/rockbox/HostCallback.java5
-rw-r--r--android/src/org/rockbox/KeyboardActivity.java49
-rw-r--r--android/src/org/rockbox/RockboxActivity.java11
-rw-r--r--android/src/org/rockbox/RockboxKeyboardInput.java51
-rw-r--r--apps/hosted/keyboard.c31
5 files changed, 78 insertions, 69 deletions
diff --git a/android/src/org/rockbox/HostCallback.java b/android/src/org/rockbox/HostCallback.java
index 0e69b3f283..8584fedd6a 100644
--- a/android/src/org/rockbox/HostCallback.java
+++ b/android/src/org/rockbox/HostCallback.java
@@ -2,6 +2,7 @@ package org.rockbox;
2 2
3import android.content.Intent; 3import android.content.Intent;
4 4
5public interface HostCallback { 5public interface HostCallback
6 public void onComplete(int resultCode, Intent data); 6{
7 public void onComplete(int resultCode, Intent data);
7} 8}
diff --git a/android/src/org/rockbox/KeyboardActivity.java b/android/src/org/rockbox/KeyboardActivity.java
index f32aae28f8..c77f686780 100644
--- a/android/src/org/rockbox/KeyboardActivity.java
+++ b/android/src/org/rockbox/KeyboardActivity.java
@@ -10,32 +10,39 @@ import android.view.LayoutInflater;
10import android.view.View; 10import android.view.View;
11import android.widget.EditText; 11import android.widget.EditText;
12 12
13public class KeyboardActivity extends Activity { 13public class KeyboardActivity extends Activity
14 public void onCreate(Bundle savedInstanceState) { 14{
15 public void onCreate(Bundle savedInstanceState)
16 {
15 super.onCreate(savedInstanceState); 17 super.onCreate(savedInstanceState);
16 LayoutInflater inflater=LayoutInflater.from(this); 18 LayoutInflater inflater=LayoutInflater.from(this);
17 View addView=inflater.inflate(R.layout.keyboardinput, null); 19 View addView=inflater.inflate(R.layout.keyboardinput, null);
18 EditText input = (EditText) addView.findViewById(R.id.KbdInput); 20 EditText input = (EditText) addView.findViewById(R.id.KbdInput);
19 input.setText(getIntent().getStringExtra("value")); 21 input.setText(getIntent().getStringExtra("value"));
20 new AlertDialog.Builder(this) 22 new AlertDialog.Builder(this)
21 .setTitle(R.string.KbdInputTitle) 23 .setTitle(R.string.KbdInputTitle)
22 .setView(addView) 24 .setView(addView)
23 .setIcon(R.drawable.icon) 25 .setIcon(R.drawable.icon)
24 .setPositiveButton(R.string.OK, new DialogInterface.OnClickListener() { 26 .setPositiveButton(R.string.OK, new DialogInterface.OnClickListener()
25 public void onClick(DialogInterface dialog, int whichButton) { 27 {
26 EditText input = (EditText)((Dialog)dialog).findViewById(R.id.KbdInput); 28 public void onClick(DialogInterface dialog, int whichButton) {
27 Editable s = input.getText(); 29 EditText input = (EditText)((Dialog)dialog)
28 getIntent().putExtra("value", s.toString()); 30 .findViewById(R.id.KbdInput);
29 setResult(RESULT_OK, getIntent()); 31 Editable s = input.getText();
30 finish(); 32 getIntent().putExtra("value", s.toString());
31 } 33 setResult(RESULT_OK, getIntent());
32 }) 34 finish();
33 .setNegativeButton(R.string.Cancel, new DialogInterface.OnClickListener() { 35 }
34 public void onClick(DialogInterface dialog, int whichButton) { 36 })
35 setResult(RESULT_CANCELED, getIntent()); 37
36 finish(); 38 .setNegativeButton(R.string.Cancel, new DialogInterface.OnClickListener()
37 } 39 {
38 }) 40 public void onClick(DialogInterface dialog, int whichButton)
39 .show(); 41 {
42 setResult(RESULT_CANCELED, getIntent());
43 finish();
44 }
45 })
46 .show();
40 } 47 }
41} 48}
diff --git a/android/src/org/rockbox/RockboxActivity.java b/android/src/org/rockbox/RockboxActivity.java
index 9eed3f48dc..fed17c67f9 100644
--- a/android/src/org/rockbox/RockboxActivity.java
+++ b/android/src/org/rockbox/RockboxActivity.java
@@ -24,7 +24,6 @@ package org.rockbox;
24import android.app.Activity; 24import android.app.Activity;
25import android.app.ProgressDialog; 25import android.app.ProgressDialog;
26import android.content.Intent; 26import android.content.Intent;
27import android.content.IntentFilter;
28import android.os.Bundle; 27import android.os.Bundle;
29import android.util.Log; 28import android.util.Log;
30import android.view.ViewGroup; 29import android.view.ViewGroup;
@@ -167,15 +166,15 @@ public class RockboxActivity extends Activity
167 if (hostcallback != null) 166 if (hostcallback != null)
168 { 167 {
169 LOG("Something has gone wrong"); 168 LOG("Something has gone wrong");
170 } 169 }
171 hostcallback = callback; 170 hostcallback = callback;
172 startActivityForResult(i, 0); 171 startActivityForResult(i, 0);
173 } 172 }
174 173
175 public void onActivityResult(int requestCode, int resultCode, Intent data) 174 public void onActivityResult(int requestCode, int resultCode, Intent data)
176 { 175 {
177 hostcallback.onComplete(resultCode, data); 176 hostcallback.onComplete(resultCode, data);
178 hostcallback = null; 177 hostcallback = null;
179 } 178 }
180 179
181 private void LOG(CharSequence text) 180 private void LOG(CharSequence text)
diff --git a/android/src/org/rockbox/RockboxKeyboardInput.java b/android/src/org/rockbox/RockboxKeyboardInput.java
index b037f6c4bb..5601b16662 100644
--- a/android/src/org/rockbox/RockboxKeyboardInput.java
+++ b/android/src/org/rockbox/RockboxKeyboardInput.java
@@ -22,48 +22,43 @@
22package org.rockbox; 22package org.rockbox;
23 23
24import android.app.Activity; 24import android.app.Activity;
25import android.content.BroadcastReceiver;
26import android.content.Intent; 25import android.content.Intent;
27import android.util.Log;
28 26
29public class RockboxKeyboardInput 27public class RockboxKeyboardInput
30{ 28{
31 private BroadcastReceiver b;
32 private String result; 29 private String result;
33 30
34 public RockboxKeyboardInput() 31 public RockboxKeyboardInput()
35 { 32 {
36 result = null; 33 result = null;
37 } 34 }
38 35
39 public void kbd_input(String text) 36 public void kbd_input(String text)
40 { 37 {
41 RockboxActivity a = (RockboxActivity) RockboxService.get_instance().get_activity(); 38 RockboxActivity a = (RockboxActivity) RockboxService.get_instance().get_activity();
42 Intent kbd = new Intent(a, KeyboardActivity.class); 39 Intent kbd = new Intent(a, KeyboardActivity.class);
43 kbd.putExtra("value", text); 40 kbd.putExtra("value", text);
44 a.waitForActivity(kbd, new HostCallback(){ 41 a.waitForActivity(kbd, new HostCallback()
45 42 {
46 @Override 43 public void onComplete(int resultCode, Intent data)
47 public void onComplete(int resultCode, Intent data) { 44 {
48 if (resultCode == Activity.RESULT_OK) 45 if (resultCode == Activity.RESULT_OK)
49 { 46 {
50 result = data.getStringExtra("value"); 47 result = data.getStringExtra("value");
51 } 48 }
52 else { 49 else {
53 result = ""; 50 result = "";
54 } 51 }
55 } 52 }
56 }); 53 });
57 } 54 }
58 public String get_result() 55 public String get_result()
59 { 56 {
60 return result; 57 return result;
61 } 58 }
62
63 public boolean is_usable()
64 {
65 return RockboxService.get_instance().get_activity() != null;
66 }
67 59
68 60 public boolean is_usable()
61 {
62 return RockboxService.get_instance().get_activity() != null;
63 }
69} 64}
diff --git a/apps/hosted/keyboard.c b/apps/hosted/keyboard.c
index be5c70c896..1993164ade 100644
--- a/apps/hosted/keyboard.c
+++ b/apps/hosted/keyboard.c
@@ -26,8 +26,8 @@
26#include <stdio.h> 26#include <stdio.h>
27#include <system.h> 27#include <system.h>
28 28
29extern JNIEnv *env_ptr; 29extern JNIEnv *env_ptr;
30static jclass RockboxKeyboardInput_class = NULL; 30static jclass RockboxKeyboardInput_class;
31static jobject RockboxKeyboardInput_instance; 31static jobject RockboxKeyboardInput_instance;
32static jmethodID kbd_inputfunc, kbd_result; 32static jmethodID kbd_inputfunc, kbd_result;
33 33
@@ -38,18 +38,24 @@ static void kdb_init(void)
38 if (RockboxKeyboardInput_class == NULL) 38 if (RockboxKeyboardInput_class == NULL)
39 { 39 {
40 /* get the class and its constructor */ 40 /* get the class and its constructor */
41 RockboxKeyboardInput_class = e->FindClass(env_ptr, "org/rockbox/RockboxKeyboardInput"); 41 RockboxKeyboardInput_class = e->FindClass(env_ptr,
42 jmethodID constructor = e->GetMethodID(env_ptr, RockboxKeyboardInput_class, "<init>", "()V"); 42 "org/rockbox/RockboxKeyboardInput");
43 RockboxKeyboardInput_instance = e->NewObject(env_ptr, RockboxKeyboardInput_class, constructor); 43 jmethodID constructor = e->GetMethodID(env_ptr,
44 RockboxKeyboardInput_class,
45 "<init>", "()V");
46 RockboxKeyboardInput_instance = e->NewObject(env_ptr,
47 RockboxKeyboardInput_class,
48 constructor);
44 kbd_inputfunc = e->GetMethodID(env_ptr, RockboxKeyboardInput_class, 49 kbd_inputfunc = e->GetMethodID(env_ptr, RockboxKeyboardInput_class,
45 "kbd_input", "(Ljava/lang/String;)V"); 50 "kbd_input", "(Ljava/lang/String;)V");
46 kbd_result = e->GetMethodID(env_ptr, RockboxKeyboardInput_class, 51 kbd_result = e->GetMethodID(env_ptr, RockboxKeyboardInput_class,
47 "get_result", "()Ljava/lang/String;"); 52 "get_result", "()Ljava/lang/String;");
48 } 53 }
49 /* need to get it every time incase the activity died/restarted */ 54 /* need to get it every time incase the activity died/restarted */
50 kbd_is_usable = e->GetMethodID(env_ptr, RockboxKeyboardInput_class, 55 kbd_is_usable = e->GetMethodID(env_ptr, RockboxKeyboardInput_class,
51 "is_usable", "()Z"); 56 "is_usable", "()Z");
52 while (!e->CallBooleanMethod(env_ptr, RockboxKeyboardInput_instance, kbd_is_usable)) 57 while (!e->CallBooleanMethod(env_ptr, RockboxKeyboardInput_instance,
58 kbd_is_usable))
53 sleep(HZ/10); 59 sleep(HZ/10);
54} 60}
55 61
@@ -61,11 +67,12 @@ int kbd_input(char* text, int buflen)
61 const char* retchars; 67 const char* retchars;
62 kdb_init(); 68 kdb_init();
63 69
64 e->CallVoidMethod(env_ptr, RockboxKeyboardInput_instance, kbd_inputfunc, str); 70 e->CallVoidMethod(env_ptr, RockboxKeyboardInput_instance,kbd_inputfunc,str);
65 71
66 do { 72 do {
67 sleep(HZ/10); 73 sleep(HZ/10);
68 ret = e->CallObjectMethod(env_ptr, RockboxKeyboardInput_instance, kbd_result); 74 ret = e->CallObjectMethod(env_ptr, RockboxKeyboardInput_instance,
75 kbd_result);
69 } while (!ret); 76 } while (!ret);
70 77
71 e->ReleaseStringUTFChars(env_ptr, str, NULL); 78 e->ReleaseStringUTFChars(env_ptr, str, NULL);