summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJens Arnold <amiconn@rockbox.org>2010-04-11 12:28:02 +0000
committerJens Arnold <amiconn@rockbox.org>2010-04-11 12:28:02 +0000
commit268c6d1e7f54379f78a8a69002ad133056f7f452 (patch)
treebca9fd19f9eef83da0be69490602a776ddcc540b
parent629bf3e94a0d550ccd8b36fd7b744d414be74b86 (diff)
downloadrockbox-268c6d1e7f54379f78a8a69002ad133056f7f452.tar.gz
rockbox-268c6d1e7f54379f78a8a69002ad133056f7f452.zip
Fix two viewport related charcell bugs: crashes in the yesno screen and the USB screen. This mess should really be fixed properly by enabling viewport management for charcell.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25587 a1c6a512-1295-4272-9138-f99709370657
-rw-r--r--apps/gui/usb_screen.c5
-rw-r--r--apps/gui/yesno.c5
2 files changed, 9 insertions, 1 deletions
diff --git a/apps/gui/usb_screen.c b/apps/gui/usb_screen.c
index 022d574c1d..019aec61ff 100644
--- a/apps/gui/usb_screen.c
+++ b/apps/gui/usb_screen.c
@@ -270,7 +270,10 @@ void gui_usb_screen_run(void)
270 struct screen *screen = &screens[i]; 270 struct screen *screen = &screens[i];
271 271
272 screen->set_viewport(NULL); 272 screen->set_viewport(NULL);
273#ifdef HAVE_LCD_BITMAP 273#ifdef HAVE_LCD_CHARCELLS
274 /* Quick fix. Viewports should really be enabled proper for charcell */
275 viewport_set_defaults(&usb_screen_vps_ar[i].parent, i);
276#else
274 usb_screen_fix_viewports(screen, &usb_screen_vps_ar[i]); 277 usb_screen_fix_viewports(screen, &usb_screen_vps_ar[i]);
275#endif 278#endif
276 } 279 }
diff --git a/apps/gui/yesno.c b/apps/gui/yesno.c
index a153a43fec..a834aa7b06 100644
--- a/apps/gui/yesno.c
+++ b/apps/gui/yesno.c
@@ -144,7 +144,12 @@ enum yesno_res gui_syncyesno_run(const struct text_message * main_message,
144 yn[i].result_message[YESNO_NO]=no_message; 144 yn[i].result_message[YESNO_NO]=no_message;
145 yn[i].display=&screens[i]; 145 yn[i].display=&screens[i];
146 yn[i].vp = &vp[i]; 146 yn[i].vp = &vp[i];
147#ifdef HAVE_LCD_CHARCELLS
148 /* Quick fix. Viewports should really be enabled proper for charcell */
149 viewport_set_defaults(yn[i].vp, i);
150#else
147 viewportmanager_theme_enable(i, true, yn[i].vp); 151 viewportmanager_theme_enable(i, true, yn[i].vp);
152#endif
148 screens[i].stop_scroll(); 153 screens[i].stop_scroll();
149 gui_yesno_draw(&(yn[i])); 154 gui_yesno_draw(&(yn[i]));
150 } 155 }