summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLinus Nielsen Feltzing <linus@haxx.se>2005-05-13 10:35:32 +0000
committerLinus Nielsen Feltzing <linus@haxx.se>2005-05-13 10:35:32 +0000
commit263068c6cd59adbe36e79195e5b7b313433271f3 (patch)
tree161e7c48b44589b7ab38d84205c0e7e8fe4e1596
parent2b1e168453dcab06f643de3377eff5dd9f135515 (diff)
downloadrockbox-263068c6cd59adbe36e79195e5b7b313433271f3.tar.gz
rockbox-263068c6cd59adbe36e79195e5b7b313433271f3.zip
File rename wrongly accepted an empty target filename, corrupting the file system
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@6468 a1c6a512-1295-4272-9138-f99709370657
-rw-r--r--apps/onplay.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/apps/onplay.c b/apps/onplay.c
index f761014bbf..78562c5bec 100644
--- a/apps/onplay.c
+++ b/apps/onplay.c
@@ -355,7 +355,7 @@ static bool rename_file(void)
355 int pathlen = (ptr - selected_file); 355 int pathlen = (ptr - selected_file);
356 strncpy(newname, selected_file, sizeof newname); 356 strncpy(newname, selected_file, sizeof newname);
357 if (!kbd_input(newname + pathlen, (sizeof newname)-pathlen)) { 357 if (!kbd_input(newname + pathlen, (sizeof newname)-pathlen)) {
358 if (!strlen(selected_file+pathlen) || 358 if (!strlen(newname + pathlen) ||
359 (rename(selected_file, newname) < 0)) { 359 (rename(selected_file, newname) < 0)) {
360 lcd_clear_display(); 360 lcd_clear_display();
361 lcd_puts(0,0,str(LANG_RENAME)); 361 lcd_puts(0,0,str(LANG_RENAME));