diff options
author | Dominik Riebeling <Dominik.Riebeling@gmail.com> | 2010-03-13 22:25:21 +0000 |
---|---|---|
committer | Dominik Riebeling <Dominik.Riebeling@gmail.com> | 2010-03-13 22:25:21 +0000 |
commit | 1e67a28cffaf7ca53755d361a8f7962bf4de0601 (patch) | |
tree | fc35a8fe796a734f021003d4e5a122122a2d11de | |
parent | 9c2baa6b17cbeb0facbbdfafefab965d7bdabb6f (diff) | |
download | rockbox-1e67a28cffaf7ca53755d361a8f7962bf4de0601.tar.gz rockbox-1e67a28cffaf7ca53755d361a8f7962bf4de0601.zip |
Fix wavtrim not working correctly on PPC.
Don't rely on the host being little endian -- PPC Macs are not, resulting in
wavtrim not trimming files at all. Also fix a printf warning while at it.
git-svn-id: svn://svn.rockbox.org/rockbox/trunk@25158 a1c6a512-1295-4272-9138-f99709370657
-rw-r--r-- | tools/wavtrim.c | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/tools/wavtrim.c b/tools/wavtrim.c index b82f270c8d..8517b4677e 100644 --- a/tools/wavtrim.c +++ b/tools/wavtrim.c | |||
@@ -167,7 +167,9 @@ int wavtrim(char * filename, int maxsilence ,char* errstring,int errsize) | |||
167 | /* clip the start */ | 167 | /* clip the start */ |
168 | for (i=0; i<datalen; i+=2) | 168 | for (i=0; i<datalen; i+=2) |
169 | { | 169 | { |
170 | sample16 = *(short *)(databuf + i); | 170 | /* samples are little endian */ |
171 | sample16 = (*(databuf + i + 1) << 8) | *(databuf + i); | ||
172 | |||
171 | if (abs(sample16) > max_silence) | 173 | if (abs(sample16) > max_silence) |
172 | break; | 174 | break; |
173 | } | 175 | } |
@@ -178,7 +180,8 @@ int wavtrim(char * filename, int maxsilence ,char* errstring,int errsize) | |||
178 | /* clip the end */ | 180 | /* clip the end */ |
179 | for (i=datalen-2; i>skip_head; i-=2) | 181 | for (i=datalen-2; i>skip_head; i-=2) |
180 | { | 182 | { |
181 | sample16 = *(short *)(databuf + i); | 183 | /* samples are little endian */ |
184 | sample16 = (*(databuf + i + 1) << 8) | *(databuf + i); | ||
182 | if (abs(sample16) > max_silence) | 185 | if (abs(sample16) > max_silence) |
183 | break; | 186 | break; |
184 | } | 187 | } |
@@ -231,7 +234,7 @@ int main (int argc, char** argv) | |||
231 | ret = wavtrim(argv[1],max_silence,errbuffer,255 ); | 234 | ret = wavtrim(argv[1],max_silence,errbuffer,255 ); |
232 | if( ret< 0) | 235 | if( ret< 0) |
233 | { | 236 | { |
234 | printf(errbuffer); | 237 | printf("%s", errbuffer); |
235 | } | 238 | } |
236 | return ret; | 239 | return ret; |
237 | } | 240 | } |