summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDana Conrad <dconrad@fastmail.com>2021-09-13 14:41:42 -0500
committerSolomon Peachy <pizza@shaftnet.org>2021-09-19 21:13:09 -0400
commit0ca0940f012566f8bb9d378386f97608d21ea8bc (patch)
tree1ea0f78e5554d034fdc3eabb93dd9d598dec4832
parent5765deb08e538b0c9d02dd3cfe40cd857a5c69ef (diff)
downloadrockbox-0ca0940f012566f8bb9d378386f97608d21ea8bc.tar.gz
rockbox-0ca0940f012566f8bb9d378386f97608d21ea8bc.zip
Make USB Charging default value configurable per device
A reasonable default assumption for a user would be that they can plug their device into a USB AC adapter and it will charge with as much current as it reasonably can. With the previous default, an AC adapter will only do 100mA, basically a trickle charge. Make this configurable default per-device, so as not to break old devices without testing. Define TARGET_USB_CHARGING_DEFAULT to USB_CHARGING_FORCE to use the new default. Tested on both erosQ Native and M3K. Change-Id: I77265d356a41d67357ebc6e9f7e0c25a37b74931
-rw-r--r--apps/settings_list.c8
-rw-r--r--firmware/export/config/erosqnative.h1
-rw-r--r--firmware/export/config/fiiom3k.h1
3 files changed, 9 insertions, 1 deletions
diff --git a/apps/settings_list.c b/apps/settings_list.c
index 4c92bb4322..d9ffd8cf3e 100644
--- a/apps/settings_list.c
+++ b/apps/settings_list.c
@@ -345,6 +345,12 @@ static const char graphic_numeric[] = "graphic,numeric";
345#endif 345#endif
346#endif /* HAVE_BACKLIGHT */ 346#endif /* HAVE_BACKLIGHT */
347 347
348#if defined(HAVE_USB_CHARGING_ENABLE)
349# if !defined(TARGET_USB_CHARGING_DEFAULT)
350# define TARGET_USB_CHARGING_DEFAULT USB_CHARGING_ENABLE
351# endif
352#endif
353
348#if LCD_DEPTH > 1 354#if LCD_DEPTH > 1
349static const char* list_pad_formatter(char *buffer, size_t buffer_size, 355static const char* list_pad_formatter(char *buffer, size_t buffer_size,
350 int val, const char *unit) 356 int val, const char *unit)
@@ -1827,7 +1833,7 @@ const struct settings_list settings[] = {
1827#endif 1833#endif
1828 TEXT_SETTING(0,kbd_file,"kbd","-",ROCKBOX_DIR "/",".kbd"), 1834 TEXT_SETTING(0,kbd_file,"kbd","-",ROCKBOX_DIR "/",".kbd"),
1829#ifdef HAVE_USB_CHARGING_ENABLE 1835#ifdef HAVE_USB_CHARGING_ENABLE
1830 CHOICE_SETTING(0, usb_charging, LANG_USB_CHARGING, 1, "usb charging", 1836 CHOICE_SETTING(0, usb_charging, LANG_USB_CHARGING, TARGET_USB_CHARGING_DEFAULT, "usb charging",
1831 "off,on,force", NULL, 3, ID2P(LANG_SET_BOOL_NO), 1837 "off,on,force", NULL, 3, ID2P(LANG_SET_BOOL_NO),
1832 ID2P(LANG_SET_BOOL_YES), ID2P(LANG_FORCE)), 1838 ID2P(LANG_SET_BOOL_YES), ID2P(LANG_FORCE)),
1833#endif 1839#endif
diff --git a/firmware/export/config/erosqnative.h b/firmware/export/config/erosqnative.h
index b2b6f3f89e..e0a668d82d 100644
--- a/firmware/export/config/erosqnative.h
+++ b/firmware/export/config/erosqnative.h
@@ -114,6 +114,7 @@
114#define USB_DEVBSS_ATTR __attribute__((aligned(32))) 114#define USB_DEVBSS_ATTR __attribute__((aligned(32)))
115#define HAVE_USB_POWER 115#define HAVE_USB_POWER
116#define HAVE_USB_CHARGING_ENABLE 116#define HAVE_USB_CHARGING_ENABLE
117#define TARGET_USB_CHARGING_DEFAULT USB_CHARGING_FORCE
117#define HAVE_BOOTLOADER_USB_MODE 118#define HAVE_BOOTLOADER_USB_MODE
118#endif 119#endif
119 120
diff --git a/firmware/export/config/fiiom3k.h b/firmware/export/config/fiiom3k.h
index 849aa9c0a6..dc56f0a5cc 100644
--- a/firmware/export/config/fiiom3k.h
+++ b/firmware/export/config/fiiom3k.h
@@ -114,6 +114,7 @@
114#define USB_DEVBSS_ATTR __attribute__((aligned(32))) 114#define USB_DEVBSS_ATTR __attribute__((aligned(32)))
115#define HAVE_USB_POWER 115#define HAVE_USB_POWER
116#define HAVE_USB_CHARGING_ENABLE 116#define HAVE_USB_CHARGING_ENABLE
117#define TARGET_USB_CHARGING_DEFAULT USB_CHARGING_FORCE
117#define HAVE_BOOTLOADER_USB_MODE 118#define HAVE_BOOTLOADER_USB_MODE
118#endif 119#endif
119 120