From a0459de4d5b4bbb062536146cdefaad796480c7c Mon Sep 17 00:00:00 2001 From: Dominik Riebeling Date: Wed, 16 Mar 2022 22:19:00 +0100 Subject: rbutil: HttpGet: Return NetworkError in done signal. Return the status value instead of simply a bool. Change-Id: I2bffaac0087418656e80c74dc352011a4ea32ab1 --- utils/rbutilqt/themesinstallwindow.cpp | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) (limited to 'utils/rbutilqt/themesinstallwindow.cpp') diff --git a/utils/rbutilqt/themesinstallwindow.cpp b/utils/rbutilqt/themesinstallwindow.cpp index e6043de892..5be60050d6 100644 --- a/utils/rbutilqt/themesinstallwindow.cpp +++ b/utils/rbutilqt/themesinstallwindow.cpp @@ -100,7 +100,7 @@ void ThemesInstallWindow::downloadInfo() } -void ThemesInstallWindow::downloadDone(bool error) +void ThemesInstallWindow::downloadDone(QNetworkReply::NetworkError error) { LOG_INFO() << "Download done, error:" << error; @@ -116,7 +116,7 @@ void ThemesInstallWindow::downloadDone(bool error) << iniDetails.value("error/description").toString() << iniDetails.value("error/query").toString(); - if(error) { + if(error != QNetworkReply::NoError) { logger->addItem(tr("Network error: %1.\n" "Please check your network and proxy settings.") .arg(getter->errorString()), LOGERROR); @@ -236,19 +236,18 @@ void ThemesInstallWindow::updateDetails(QListWidgetItem* cur, QListWidgetItem* p } -void ThemesInstallWindow::updateImage(bool error) +void ThemesInstallWindow::updateImage(QNetworkReply::NetworkError error) { LOG_INFO() << "Updating image:"<< !error; - if(error) { + if(error != QNetworkReply::NoError) { ui.themePreview->clear(); ui.themePreview->setText(tr("Retrieving theme preview failed.\n" "HTTP response code: %1").arg(igetter.httpResponse())); return; } - - QPixmap p; - if(!error) { + else { + QPixmap p; imgData = igetter.readAll(); if(imgData.isNull()) return; p.loadFromData(imgData); -- cgit v1.2.3