From 37a60d54619e957cbc3f7d9a49bd152f674df8e6 Mon Sep 17 00:00:00 2001
From: Dominik Riebeling <Dominik.Riebeling@gmail.com>
Date: Sun, 17 Apr 2022 22:28:13 +0200
Subject: rbutil: Enable themes install depending on theme selection.

Don't store the "Install Themes" option. Automatically enable themes
installation if the themes selection has at least one entry selected
instead.

Change-Id: Ib46e8b53b0204555b79dea51545dd7c380f003ff
---
 utils/rbutilqt/themesinstallwindow.cpp | 22 +++++++---------------
 1 file changed, 7 insertions(+), 15 deletions(-)

(limited to 'utils/rbutilqt/themesinstallwindow.cpp')

diff --git a/utils/rbutilqt/themesinstallwindow.cpp b/utils/rbutilqt/themesinstallwindow.cpp
index 7edfc91cd1..3dd564c5e5 100644
--- a/utils/rbutilqt/themesinstallwindow.cpp
+++ b/utils/rbutilqt/themesinstallwindow.cpp
@@ -44,7 +44,7 @@ ThemesInstallWindow::ThemesInstallWindow(QWidget *parent) : QDialog(parent)
     ui.themeDescription->setLayoutDirection(Qt::LeftToRight);
 
     connect(ui.buttonCancel, &QAbstractButton::clicked, this, &QWidget::close);
-    connect(ui.buttonOk, &QAbstractButton::clicked, this, &ThemesInstallWindow::accept);
+    connect(ui.buttonOk, &QAbstractButton::clicked, this, &ThemesInstallWindow::buttonOk);
     connect(ui.listThemes, &QListWidget::currentItemChanged,
             this, &ThemesInstallWindow::updateDetails);
     connect(ui.listThemes, &QListWidget::itemSelectionChanged, this, &ThemesInstallWindow::updateSize);
@@ -287,8 +287,7 @@ void ThemesInstallWindow::resizeEvent(QResizeEvent* e)
 void ThemesInstallWindow::show()
 {
     QDialog::show();
-    if(windowSelectOnly)
-        ui.buttonOk->setText(tr("Select"));
+    ui.buttonOk->setText(tr("Select"));
 
     if(!logger)
         logger = new ProgressLoggerGui(this);
@@ -309,16 +308,14 @@ void ThemesInstallWindow::abort()
 {
     igetter.abort();
     logger->setFinished();
-    this->close();
+    close();
 }
 
 
-void ThemesInstallWindow::accept(void)
+void ThemesInstallWindow::buttonOk(void)
 {
-    if(!windowSelectOnly)
-        install();
-    else
-        close();
+    emit selected(ui.listThemes->selectedItems().size());
+    close();
 }
 
 
@@ -326,7 +323,6 @@ void ThemesInstallWindow::install()
 {
     if(ui.listThemes->selectedItems().size() == 0) {
         logger->addItem(tr("No themes selected, skipping"), LOGINFO);
-        emit done(false);
         return;
     }
     QStringList themes;
@@ -368,13 +364,9 @@ void ThemesInstallWindow::install()
     if(!RbSettings::value(RbSettings::CacheDisabled).toBool())
         installer->setCache(true);
 
-    if(!windowSelectOnly) {
-        connect(logger, &ProgressLoggerGui::closed, this, &QWidget::close);
-        connect(installer, &ZipInstaller::done, logger, &ProgressLoggerGui::setFinished);
-    }
     connect(installer, &ZipInstaller::logItem, logger, &ProgressLoggerGui::addItem);
     connect(installer, &ZipInstaller::logProgress, logger, &ProgressLoggerGui::setProgress);
-    connect(installer, &ZipInstaller::done, this, &ThemesInstallWindow::done);
+    connect(installer, &ZipInstaller::done, this, &ThemesInstallWindow::finished);
     connect(logger, &ProgressLoggerGui::aborted, installer, &ZipInstaller::abort);
     installer->install();
 }
-- 
cgit v1.2.3