From f53f1fbafab6f994a4ed5f63d884d27c42739d53 Mon Sep 17 00:00:00 2001
From: Dominik Riebeling <Dominik.Riebeling@gmail.com>
Date: Tue, 28 Dec 2021 16:40:16 +0100
Subject: rbutil: Fix some more issues found by clazy.

Change-Id: I0a1a849ecea4b4666b08ccb050eb17918e90a258
---
 utils/rbutilqt/rbutilqt.cpp | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

(limited to 'utils/rbutilqt/rbutilqt.cpp')

diff --git a/utils/rbutilqt/rbutilqt.cpp b/utils/rbutilqt/rbutilqt.cpp
index a9878646da..d0ff9f2799 100644
--- a/utils/rbutilqt/rbutilqt.cpp
+++ b/utils/rbutilqt/rbutilqt.cpp
@@ -279,11 +279,11 @@ void RbUtilQt::about()
     licenses[":/docs/LICENSE.BZIP2"] = "<a id='bzip2'>bzip2 License</a>";
     licenses[":/docs/LICENSE.BSPATCH"] = "<a id='bspatch'>bspatch License</a>";
 
-    for (auto const& key : licenses.keys()) {
-        QFile license(key);
+    for (auto it = licenses.keyBegin(); it != licenses.keyEnd(); ++it) {
+        QFile license(*it);
         license.open(QIODevice::ReadOnly);
         QTextStream s(&license);
-        about.browserLicenses->insertHtml("<hr/><h2>" + licenses[key] + "</h2><br/>\n");
+        about.browserLicenses->insertHtml("<hr/><h2>" + licenses[*it] + "</h2><br/>\n");
         about.browserLicenses->insertHtml("<pre>" + s.readAll() + "</pre>");
         license.close();
     }
@@ -675,7 +675,7 @@ void RbUtilQt::downloadUpdateDone(bool error)
                         tr("<b>New Rockbox Utility version available.</b><br><br>"
                            "You are currently using version %1. "
                            "Get version %2 at <a href='%3'>%3</a>")
-                           .arg(VERSION).arg(Utils::trimVersionString(foundVersion)).arg(url));
+                           .arg(VERSION, Utils::trimVersionString(foundVersion), url));
             ui.statusbar->showMessage(tr("New version of Rockbox Utility available."));
         }
         else {
-- 
cgit v1.2.3