From 01e245417e24fe6c9957b35850db6b1473f66e98 Mon Sep 17 00:00:00 2001 From: Dominik Riebeling Date: Sat, 25 Dec 2021 19:59:57 +0100 Subject: rbutil: Fix various issues found by clazy. Change-Id: I91ca2baed34f0f3b561602f95f66bbd4e17e74ab --- utils/rbutilqt/gui/selectiveinstallwidget.cpp | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) (limited to 'utils/rbutilqt/gui/selectiveinstallwidget.cpp') diff --git a/utils/rbutilqt/gui/selectiveinstallwidget.cpp b/utils/rbutilqt/gui/selectiveinstallwidget.cpp index 3fe2dc7956..341a4072cc 100644 --- a/utils/rbutilqt/gui/selectiveinstallwidget.cpp +++ b/utils/rbutilqt/gui/selectiveinstallwidget.cpp @@ -277,7 +277,6 @@ void SelectiveInstallWidget::installBootloader(void) if(ui.bootloaderCheckbox->isChecked()) { LOG_INFO() << "installing bootloader"; - QString platform = RbSettings::value(RbSettings::Platform).toString(); QString backupDestination = ""; // create installer @@ -509,7 +508,6 @@ void SelectiveInstallWidget::installVoicefile(void) RockboxInfo installInfo(m_mountpoint); QString voiceurl; QString logversion; - QString relversion = installInfo.release(); if(m_buildtype != PlayerBuildInfo::TypeRelease) { // release is empty for non-release versions (i.e. daily / current) logversion = installInfo.release(); @@ -549,7 +547,6 @@ void SelectiveInstallWidget::installManual(void) RockboxInfo installInfo(m_mountpoint); QString manualurl; QString logversion; - QString relversion = installInfo.release(); if(m_buildtype != PlayerBuildInfo::TypeRelease) { // release is empty for non-release versions (i.e. daily / current) logversion = installInfo.release(); @@ -638,7 +635,7 @@ void SelectiveInstallWidget::installPluginData(void) for(size_t i = 0; i < sizeof(PluginDataFiles) / sizeof(PluginDataFiles[0]); i++) { // check if installed Rockbox has this plugin. - if(QFileInfo(m_mountpoint + "/.rockbox/rocks/" + PluginDataFiles[i].rockfile).exists()) { + if(QFileInfo::exists(m_mountpoint + "/.rockbox/rocks/" + PluginDataFiles[i].rockfile)) { dataName.append(PluginDataFiles[i].name); // game URLs do not depend on the actual build type, but we need // to pass it (simplifies the API, and will allow to make them -- cgit v1.2.3