From 9476883d2d7e89d81719daf81664f565cbbc883c Mon Sep 17 00:00:00 2001 From: Thomas Jarosch Date: Wed, 29 Feb 2012 19:08:43 +0100 Subject: Fix sanity check in UnwStartThumb() using the wrong register cppcheck reported: [lib/unwarminder/unwarm_thumb.c:399] -> [lib/unwarminder/unwarm_thumb.c:399]: (style) Same expression on both sides of '&&'. Patch will also be sent to the upstream project. Change-Id: I57033f290135f4dc09ac7e9b07c31461bc5b471a Reviewed-on: http://gerrit.rockbox.org/157 Reviewed-by: Thomas Jarosch --- lib/unwarminder/unwarm_thumb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'lib') diff --git a/lib/unwarminder/unwarm_thumb.c b/lib/unwarminder/unwarm_thumb.c index 09b3c9e54b..027d951f33 100644 --- a/lib/unwarminder/unwarm_thumb.c +++ b/lib/unwarminder/unwarm_thumb.c @@ -396,7 +396,7 @@ UnwResult UnwStartThumb(UnwState * const state) case 12: /* ORR */ case 13: /* MUL */ case 14: /* BIC */ - if(M_IsOriginValid(state->regData[rs].o) && M_IsOriginValid(state->regData[rs].o)) + if(M_IsOriginValid(state->regData[rd].o) && M_IsOriginValid(state->regData[rs].o)) { state->regData[rd].o = state->regData[rs].o; state->regData[rd].o |= REG_VAL_ARITHMETIC; -- cgit v1.2.3