From 8a8fd3d4a33eaca67669a2b5039c6bb022af2ad3 Mon Sep 17 00:00:00 2001 From: William Wilgus Date: Fri, 6 Aug 2021 20:53:30 -0400 Subject: metadata/mp3data.c set data to 0 in case of read error Change-Id: I15d4e3d3be4bf4531c892f4351355b0b2e8e0ca9 --- lib/rbcodec/metadata/mp3data.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'lib/rbcodec') diff --git a/lib/rbcodec/metadata/mp3data.c b/lib/rbcodec/metadata/mp3data.c index f30e954e93..664084021c 100644 --- a/lib/rbcodec/metadata/mp3data.c +++ b/lib/rbcodec/metadata/mp3data.c @@ -215,10 +215,9 @@ static bool headers_have_same_type(unsigned long header1, /* Helper function to read 4-byte in big endian format. */ static void read_uint32be_mp3data(int fd, unsigned long *data) { -#ifdef ROCKBOX_BIG_ENDIAN - (void)read(fd, (char*)data, 4); -#else + *data = 0; (void)read(fd, (char*)data, 4); +#ifndef ROCKBOX_BIG_ENDIAN *data = betoh32(*data); #endif } -- cgit v1.2.3