From 022dfe7ab3ae17987763a1838e274dd7be4482d6 Mon Sep 17 00:00:00 2001 From: Solomon Peachy Date: Sat, 28 Mar 2020 06:38:16 -0400 Subject: sid: Fix an out-of-bounds read in the channel mixing code Change-Id: Ie25b8ab90193e6bb580cd7c04f8c0ce281f7a301 --- lib/rbcodec/codecs/sid.c | 1 - 1 file changed, 1 deletion(-) (limited to 'lib/rbcodec/codecs/sid.c') diff --git a/lib/rbcodec/codecs/sid.c b/lib/rbcodec/codecs/sid.c index 224b47d750..6ce11b34cb 100644 --- a/lib/rbcodec/codecs/sid.c +++ b/lib/rbcodec/codecs/sid.c @@ -554,7 +554,6 @@ void synth_render (int32_t *buffer_r, int32_t *buffer_l, unsigned long len) * This filter sounds a lot like the 8580, as the low-quality, dirty * sound of the 6581 is uuh too hard to achieve :) */ - outf[0]+=outf[2]; /* mix voice 1 and 3 to right channel */ for (v=0;v<2;v++) { /* do step 3 for both channels */ filter.h = quickfloat_ConvertFromInt(outf[v]) - (filter.b>>8)*filter.rez - filter.l; filter.b += quickfloat_Multiply(filter.freq, filter.h); -- cgit v1.2.3