From dbacee67c415abdd799580efe7949d8012739017 Mon Sep 17 00:00:00 2001 From: Michael Sevakis Date: Thu, 13 Apr 2017 18:56:13 -0400 Subject: Optimize lld_remove() a bit Just need to check prev and next for NULL to know whether to mess with the head and/or tail pointers. Change-Id: I0aee057111e11735b7806e7214af0a6038f0ab53 --- firmware/common/linked_list.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) (limited to 'firmware') diff --git a/firmware/common/linked_list.c b/firmware/common/linked_list.c index a5b3de3cf7..b8f2dd181c 100644 --- a/firmware/common/linked_list.c +++ b/firmware/common/linked_list.c @@ -198,16 +198,14 @@ void lld_remove(struct lld_head *list, struct lld_node *node) struct lld_node *next = node->next; struct lld_node *prev = node->prev; - if (node == list->head) + if (prev == NULL) list->head = next; - - if (node == list->tail) - list->tail = prev; - - if (prev != NULL) + else prev->next = next; - if (next != NULL) + if (next == NULL) + list->tail = prev; + else next->prev = prev; } -- cgit v1.2.3