From c66a66728c855456a465a57504344038b3224dd9 Mon Sep 17 00:00:00 2001 From: Marcin Bukat Date: Tue, 12 Feb 2013 08:48:43 +0100 Subject: rk27xx: do not disable irq in commit_discard_dcache_range() commit_discard_dcache_range() is used in sd, lcd and pcm drivers to handle transfers form/to data buffers so this should not introduce any problems. It is reported to fix pop noise observed on some hifimans. We apparently don't fully understand cache handling on this platform. Change-Id: I436d291509f91d16a13d10965a28171fb27574ab --- firmware/target/arm/rk27xx/system-rk27xx.c | 4 ---- 1 file changed, 4 deletions(-) (limited to 'firmware') diff --git a/firmware/target/arm/rk27xx/system-rk27xx.c b/firmware/target/arm/rk27xx/system-rk27xx.c index 712c7d6549..9f089e8170 100644 --- a/firmware/target/arm/rk27xx/system-rk27xx.c +++ b/firmware/target/arm/rk27xx/system-rk27xx.c @@ -222,8 +222,6 @@ void commit_discard_dcache_range (const void *base, unsigned int size) uint32_t end_opcode = (uint32_t)((uintptr_t)base + size) | 0x01; uint32_t opcode = (uint32_t)((uintptr_t)base & 0xffffffe0) | 0x01; - int old_irq = disable_irq_save(); - while (opcode <= end_opcode) { while (CACHEOP & 0x03); @@ -231,8 +229,6 @@ void commit_discard_dcache_range (const void *base, unsigned int size) CACHEOP = opcode; opcode += 32; } - - restore_irq(old_irq); } #ifdef HAVE_ADJUSTABLE_CPU_FREQ -- cgit v1.2.3