From c13f21a4d5c27c638c9f0dedf6d7b1f9bbb4d682 Mon Sep 17 00:00:00 2001 From: Amaury Pouly Date: Fri, 16 Aug 2013 21:55:09 +0200 Subject: Fix logdisk The code was broken in a subtle but crucial way: storage idle callbacks are oneshot so after the first flush everything would stay in the buffer forever and would never be written to the disk thus resulting into many events being lost. This changed correctly registers the idle callback each time the buffer is not empty. Note that the idle storage code checks if a callback has is in the queue already so we don't register twice. Change-Id: Ifdf331d4b757e05b8a6902bf5926cbc7689f5109 --- firmware/logf.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) (limited to 'firmware') diff --git a/firmware/logf.c b/firmware/logf.c index e135b0b27f..fadfc9bb13 100644 --- a/firmware/logf.c +++ b/firmware/logf.c @@ -273,6 +273,8 @@ static int logdiskf_push(void *userp, unsigned char c) return true; } +static void flush_buffer(void* data); + void _logdiskf(const char* file, const char level, const char *fmt, ...) { @@ -296,9 +298,9 @@ void _logdiskf(const char* file, const char level, const char *fmt, ...) vuprintf(logdiskf_push, NULL, fmt, ap); va_end(ap); - - + register_storage_idle_func(flush_buffer); } + static void flush_buffer(void* data) { (void)data; @@ -316,8 +318,4 @@ static void flush_buffer(void* data) logdiskfindex = 0; } -void init_logdiskf() -{ - register_storage_idle_func(flush_buffer); -} #endif -- cgit v1.2.3