From 79d26ed7f96537363ee752068d080e4416c14086 Mon Sep 17 00:00:00 2001
From: Michael Sparmann <theseven@rockbox.org>
Date: Sat, 13 Nov 2010 15:41:18 +0000
Subject: Reduce the amount of stack space needed by fat_rename and
 mkdir_uncached.

git-svn-id: svn://svn.rockbox.org/rockbox/trunk@28576 a1c6a512-1295-4272-9138-f99709370657
---
 firmware/common/dir_uncached.c | 25 ++++++++++++++++++++++---
 firmware/drivers/fat.c         | 20 +++++++-------------
 2 files changed, 29 insertions(+), 16 deletions(-)

(limited to 'firmware')

diff --git a/firmware/common/dir_uncached.c b/firmware/common/dir_uncached.c
index 2ce23e8b8e..e4c4397fe2 100644
--- a/firmware/common/dir_uncached.c
+++ b/firmware/common/dir_uncached.c
@@ -204,13 +204,28 @@ int mkdir_uncached(const char *name)
     char *basename;
     char *parent;
     struct dirent_uncached *entry;
-    struct fat_dir newdir;
+    int dd;
+    DIR_UNCACHED* pdir = opendirs;
+    struct fat_dir *newdir;
     int rc;
 
     if ( name[0] != '/' ) {
         DEBUGF("mkdir: Only absolute paths supported right now\n");
         return -1;
     }
+    /* find a free dir descriptor */
+    for ( dd=0; dd<MAX_OPEN_DIRS; dd++, pdir++)
+        if ( !pdir->busy )
+            break;
+
+    if ( dd == MAX_OPEN_DIRS ) {
+        DEBUGF("Too many dirs open\n");
+        errno = EMFILE;
+        return -5;
+    }
+
+    pdir->busy = true;
+    newdir = &pdir->fatdir;
 
     strlcpy(namecopy, name, sizeof(namecopy));
 
@@ -230,11 +245,13 @@ int mkdir_uncached(const char *name)
     
     if(!dir) {
         DEBUGF("mkdir: can't open parent dir\n");
+        pdir->busy = false;
         return -2;
     }    
 
     if(basename[0] == 0) {
         DEBUGF("mkdir: Empty dir name\n");
+        pdir->busy = false;
         errno = EINVAL;
         return -3;
     }
@@ -245,14 +262,16 @@ int mkdir_uncached(const char *name)
             DEBUGF("mkdir error: file exists\n");
             errno = EEXIST;
             closedir_uncached(dir);
+            pdir->busy = false;
             return - 4;
         }
     }
 
-    memset(&newdir, 0, sizeof(struct fat_dir));
+    memset(newdir, 0, sizeof(struct fat_dir));
     
-    rc = fat_create_dir(basename, &newdir, &(dir->fatdir));
+    rc = fat_create_dir(basename, newdir, &(dir->fatdir));
     closedir_uncached(dir);
+    pdir->busy = false;
     
     return rc;
 }
diff --git a/firmware/drivers/fat.c b/firmware/drivers/fat.c
index c97772361e..c640e6e737 100644
--- a/firmware/drivers/fat.c
+++ b/firmware/drivers/fat.c
@@ -1967,7 +1967,7 @@ int fat_rename(struct fat_file* file,
                 int attr)
 {
     int rc;
-    struct fat_dir olddir;
+    struct fat_file olddir_file;
     struct fat_file newfile = *file;
     unsigned char* entry = NULL;
     unsigned short* clusptr = NULL;
@@ -1988,11 +1988,6 @@ int fat_rename(struct fat_file* file,
         return -2;
     }
 
-    /* create a temporary file handle */
-    rc = fat_opendir(IF_MV2(file->volume,) &olddir, file->dircluster, NULL);
-    if (rc < 0)
-        return rc * 10 - 1;
-
     /* create new name */
     rc = add_dir_entry(dir, &newfile, newname, false, false);
     if (rc < 0)
@@ -2016,18 +2011,17 @@ int fat_rename(struct fat_file* file,
        it points to its parent directory (we don't check if it was a move) */
     if(FAT_ATTR_DIRECTORY == attr) {
         unsigned char buf[SECTOR_SIZE];
-        /* open the dir that was renamed, we re-use the olddir struct */
-        rc = fat_opendir(IF_MV2(file->volume,) &olddir, newfile.firstcluster,
-                                                                          NULL);
+        /* open the dir that was renamed, we re-use the olddir_file struct */
+        rc = fat_open(IF_MV2(volume,) newfile.firstcluster, &olddir_file, NULL);
         if (rc < 0)
             return rc * 10 - 6;
 
         /* get the first sector of the dir */
-        rc = fat_seek(&olddir.file, 0);
+        rc = fat_seek(&olddir_file, 0);
         if (rc < 0)
             return rc * 10 - 7;
 
-        rc = fat_readwrite(&olddir.file, 1, buf, false);
+        rc = fat_readwrite(&olddir_file, 1, buf, false);
         if (rc < 0)
             return rc * 10 - 8;
 
@@ -2051,11 +2045,11 @@ int fat_rename(struct fat_file* file,
         *clusptr = htole16(parentcluster & 0xffff);
 
         /* write back this sector */
-        rc = fat_seek(&olddir.file, 0);
+        rc = fat_seek(&olddir_file, 0);
         if (rc < 0)
             return rc * 10 - 7;
 
-        rc = fat_readwrite(&olddir.file, 1, buf, true);
+        rc = fat_readwrite(&olddir_file, 1, buf, true);
         if (rc < 1)
             return rc * 10 - 8;
     }
-- 
cgit v1.2.3