From 1eb1bc24f2debaaaef31db2872c800bd4d98fcf4 Mon Sep 17 00:00:00 2001 From: Thomas Jarosch Date: Sat, 20 Dec 2014 14:59:19 +0100 Subject: DX 50: Fix file descriptor leak on error Unimportant change, still good style. cppcheck reported: [rockbox/firmware/target/hosted/android/dx50/button-dx50.c:92]: (error) Resource leak: fd [rockbox/firmware/target/hosted/android/dx50/button-dx50.c:98]: (error) Resource leak: fd Change-Id: Ic1831382219c44e7bef71cb2391646c9910d2369 --- firmware/target/hosted/android/dx50/button-dx50.c | 2 ++ 1 file changed, 2 insertions(+) (limited to 'firmware') diff --git a/firmware/target/hosted/android/dx50/button-dx50.c b/firmware/target/hosted/android/dx50/button-dx50.c index 5ab58ce420..250b448491 100644 --- a/firmware/target/hosted/android/dx50/button-dx50.c +++ b/firmware/target/hosted/android/dx50/button-dx50.c @@ -89,12 +89,14 @@ static int open_device(const char *device, int print_flags) new_ufds = realloc(ufds, sizeof(ufds[0]) * (nfds + 1)); if(new_ufds == NULL) { fprintf(stderr, "out of memory\n"); + close(fd); return -1; } ufds = new_ufds; new_device_names = realloc(device_names, sizeof(device_names[0]) * (nfds + 1)); if(new_device_names == NULL) { fprintf(stderr, "out of memory\n"); + close(fd); return -1; } device_names = new_device_names; -- cgit v1.2.3