From fc9695eb47732e1c189e2f033dbd55e5c346e8c4 Mon Sep 17 00:00:00 2001 From: Michael Sevakis Date: Mon, 30 Jan 2017 09:52:05 -0500 Subject: Improve radio RDS driver and framework * Remove unused bits like the radio event and simplify basic radio interface. It can be more self-contained with rds.h only required by radio and tuner code. * Add post-processing to text a-la Silicon Labs AN243. The chip's error correction can only do so much; additional checks are highly recommended. Simply testing for two identical messages in a row is extremely effective and I've never seen corrupted text since doing that, even with mediocre reception. Groups segments must arrive in order, not randomly; logic change only accepts them in order, starting at 0. Time readout was made a bit better but really we'd need to use verbose mode and ensure that no errors were seen during receiving of time and more checks would be need to have a stable PI. The text is the important bit anyway. * Time out of stale text. * Text is no longer updated until a complete group has been received, as is specified in the standard. Perhaps go back to scrolling text lines in the radio screen? * Add proper character conversion to UTF-8. Only the default G0 table for the moment. The other two could be added in. * Add variants "RDS_CFG_PROCESS" and "RDS_CFG_PUSH" to allow the option for processed RDS data to be pushed to the driver and still do proper post-processing (only text conversion for now for the latter). Change-Id: I4d83f8b2e89a209a5096d15ec266477318c66925 --- firmware/target/hosted/samsungypr/radio-ypr.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) (limited to 'firmware/target/hosted/samsungypr') diff --git a/firmware/target/hosted/samsungypr/radio-ypr.c b/firmware/target/hosted/samsungypr/radio-ypr.c index 1929bb7c90..af49c4c3f2 100644 --- a/firmware/target/hosted/samsungypr/radio-ypr.c +++ b/firmware/target/hosted/samsungypr/radio-ypr.c @@ -29,7 +29,6 @@ #include "kernel.h" #include "radio-ypr.h" -#include "rds.h" #include "si4700.h" #include "power.h" @@ -79,7 +78,6 @@ int fmradio_i2c_read(unsigned char address, unsigned char* buf, int count) /* Low-level RDS Support */ static struct event_queue rds_queue; static uint32_t rds_stack[DEFAULT_STACK_SIZE / sizeof(uint32_t)]; -static uint16_t rds_data[4]; enum { Q_POWERUP, @@ -101,8 +99,7 @@ static void NORETURN_ATTR rds_thread(void) case SYS_TIMEOUT: /* Captures RDS data and processes it */ if ((si4709_read_reg(STATUSRSSI) & STATUSRSSI_RDSR) >> 8) { - if (si4700_rds_read_raw(rds_data) && rds_process(rds_data)) - si4700_rds_set_event(); + si4700_rds_process(); } break; } @@ -121,6 +118,5 @@ void si4700_rds_init(void) queue_init(&rds_queue, false); create_thread(rds_thread, rds_stack, sizeof(rds_stack), 0, "rds" IF_PRIO(, PRIORITY_PLAYBACK) IF_COP(, CPU)); - rds_init(); } #endif /* HAVE_RDS_CAP */ -- cgit v1.2.3