From f18f9a806142f96f435480473796e12b4a11e7b4 Mon Sep 17 00:00:00 2001 From: Linus Nielsen Feltzing Date: Tue, 25 Jul 2006 15:21:31 +0000 Subject: Patch FS#5712 by Michael Sevakis - X5 Backlight brightness improvement/fix git-svn-id: svn://svn.rockbox.org/rockbox/trunk@10322 a1c6a512-1295-4272-9138-f99709370657 --- firmware/target/coldfire/iaudio/x5/backlight-x5.c | 5 ++--- firmware/target/coldfire/iaudio/x5/pcf50606-x5.c | 10 ++++++++-- 2 files changed, 10 insertions(+), 5 deletions(-) (limited to 'firmware/target/coldfire') diff --git a/firmware/target/coldfire/iaudio/x5/backlight-x5.c b/firmware/target/coldfire/iaudio/x5/backlight-x5.c index e48e55d27b..2b09d14b55 100755 --- a/firmware/target/coldfire/iaudio/x5/backlight-x5.c +++ b/firmware/target/coldfire/iaudio/x5/backlight-x5.c @@ -25,14 +25,13 @@ void __backlight_on(void) { int level = set_irq_level(HIGHEST_IRQ_LEVEL); - pcf50606_write(0x38, 0x30); /* Backlight ON */ + pcf50606_write(0x38, 0xb0); /* Backlight ON, GPO1INV=1, GPO1ACT=011 */ set_irq_level(level); } void __backlight_off(void) { int level = set_irq_level(HIGHEST_IRQ_LEVEL); - pcf50606_write(0x38, 0x70); /* Backlight OFF */ + pcf50606_write(0x38, 0x80); /* Backlight OFF, GPO1INV=1, GPO1ACT=000 */ set_irq_level(level); } - diff --git a/firmware/target/coldfire/iaudio/x5/pcf50606-x5.c b/firmware/target/coldfire/iaudio/x5/pcf50606-x5.c index da13f1d65e..158e0fbbab 100644 --- a/firmware/target/coldfire/iaudio/x5/pcf50606-x5.c +++ b/firmware/target/coldfire/iaudio/x5/pcf50606-x5.c @@ -169,6 +169,12 @@ void pcf50606_init(void) pcf50606_write(0x39, 0x00); /* GPOOD0 = green led OFF */ pcf50606_write(0x3a, 0x00); /* GPOOD1 = red led OFF */ - pcf50606_write(0x35, 0xf1); /* Backlight PWM = 7kHz 8/16 */ - pcf50606_write(0x38, 0x30); /* Backlight ON */ + /* D305A datasheet says PWM clock frequency should be 400Hz - 2000Hz so + * I changed it from 7kHz to 512Hz. The lower frequency looks the same. + * GPO1 is also inverted so that display brightness increases with PWM + * setting which also lets the X5 share the H300's + * set_backlight_brightness code. + */ + pcf50606_write(0x35, 0x11); /* Backlight PWM = 512Hz, 8/16, Active */ + pcf50606_write(0x38, 0xb0); /* Backlight ON, GPO1INV=1, GPO1ACT=011 */ } -- cgit v1.2.3