From 0f19f4713d3fa7a9857d16820894654207044388 Mon Sep 17 00:00:00 2001 From: Jack Halpin Date: Tue, 15 Dec 2009 06:11:29 +0000 Subject: Sansa AMS: Add MCI_RESPONSE_ERROR macro to make code function more obvious. MCI_RESPONSE_ERROR covers MCI_CMD_TIMEOUT & MCI_CMD_CRC_FAIL and makes it more clear that these are errors in the response and not the command itself. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@24003 a1c6a512-1295-4272-9138-f99709370657 --- firmware/target/arm/as3525/ata_sd_as3525.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'firmware/target/arm') diff --git a/firmware/target/arm/as3525/ata_sd_as3525.c b/firmware/target/arm/as3525/ata_sd_as3525.c index 754b1ec749..85b1daff5e 100644 --- a/firmware/target/arm/as3525/ata_sd_as3525.c +++ b/firmware/target/arm/as3525/ata_sd_as3525.c @@ -86,6 +86,10 @@ | MCI_RX_OVERRUN \ | MCI_START_BIT_ERR) +#define MCI_RESPONSE_ERROR \ + ( MCI_CMD_TIMEOUT \ + | MCI_CMD_CRC_FAIL) + #define MCI_FIFO(i) ((unsigned long *) (pl180_base[i]+0x80)) /* volumes */ #define INTERNAL_AS3525 0 /* embedded SD card */ @@ -234,7 +238,7 @@ static bool send_cmd(const int drive, const int cmd, const int arg, { response[0] = MCI_RESP0(drive); /* Always prepare short response */ - if(status & (MCI_CMD_TIMEOUT | MCI_CMD_CRC_FAIL)) /* failed response */ + if(status & MCI_RESPONSE_ERROR) /* timeout or crc failure */ return false; if(status & MCI_CMD_RESP_END) /*Response passed CRC check */ -- cgit v1.2.3