From 9c53fa1b0ad35c314c5b18775856032fb200bcbb Mon Sep 17 00:00:00 2001 From: Solomon Peachy Date: Tue, 16 Jul 2024 13:36:02 -0400 Subject: pp5020: It's okay to use DMA reads on non-SSDs Fixes a regression introduced in 4b423e21f697af Change-Id: Ief4a4a562840524b98ad5988999bac87586dec41 --- firmware/target/arm/pp/ata-pp5020.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) (limited to 'firmware/target/arm/pp/ata-pp5020.c') diff --git a/firmware/target/arm/pp/ata-pp5020.c b/firmware/target/arm/pp/ata-pp5020.c index 176e74993c..f247a44171 100644 --- a/firmware/target/arm/pp/ata-pp5020.c +++ b/firmware/target/arm/pp/ata-pp5020.c @@ -175,11 +175,12 @@ bool ata_dma_setup(void *addr, unsigned long bytes, bool write) { /* Writes only need to be word-aligned, but by default DMA * is not used for writing on non-SSDs as it appears to be slower. */ - if (!ata_disk_isssd()) - return false; - - if (write && ((unsigned long)addr & 3)) - return false; + if (write) { + if ((unsigned long)addr & 3) + return false; + if (!ata_disk_isssd()) + return false; + } #if ATA_MAX_UDMA > 2 if (dma_needs_boost && !dma_boosted) { -- cgit v1.2.3