From 5b08f1a5b99136ef052b6f430b62bc618cd44946 Mon Sep 17 00:00:00 2001 From: Michael Sevakis Date: Sat, 30 Aug 2014 11:28:50 -0400 Subject: Remove I/O priority. It is harmful when used with the new file code. HAVE_IO_PRIORITY was defined for native targets with dircache. It is already effectively disabled for the most part since dircache no longer lowers its thread's I/O priority. It existed primarily for the aforementioned configuration. Change-Id: Ia04935305397ba14df34647c8ea29c2acaea92aa --- firmware/kernel/include/thread.h | 5 ----- firmware/kernel/thread-internal.h | 3 --- firmware/kernel/thread.c | 18 ------------------ 3 files changed, 26 deletions(-) (limited to 'firmware/kernel') diff --git a/firmware/kernel/include/thread.h b/firmware/kernel/include/thread.h index dfb632785e..a4f338ed0c 100644 --- a/firmware/kernel/include/thread.h +++ b/firmware/kernel/include/thread.h @@ -169,11 +169,6 @@ int thread_set_priority(unsigned int thread_id, int priority); int thread_get_priority(unsigned int thread_id); #endif /* HAVE_PRIORITY_SCHEDULING */ -#ifdef HAVE_IO_PRIORITY -void thread_set_io_priority(unsigned int thread_id, int io_priority); -int thread_get_io_priority(unsigned int thread_id); -#endif /* HAVE_IO_PRIORITY */ - #if NUM_CORES > 1 unsigned int switch_core(unsigned int new_core); #endif diff --git a/firmware/kernel/thread-internal.h b/firmware/kernel/thread-internal.h index 10606a54a6..868e57c65c 100644 --- a/firmware/kernel/thread-internal.h +++ b/firmware/kernel/thread-internal.h @@ -134,9 +134,6 @@ struct thread_entry #ifdef HAVE_SCHEDULER_BOOSTCTRL unsigned char cpu_boost; /* CPU frequency boost flag */ #endif -#ifdef HAVE_IO_PRIORITY - unsigned char io_priority; -#endif }; /* Thread ID, 32 bits = |VVVVVVVV|VVVVVVVV|VVVVVVVV|SSSSSSSS| */ diff --git a/firmware/kernel/thread.c b/firmware/kernel/thread.c index 05c09dc594..ea76421389 100644 --- a/firmware/kernel/thread.c +++ b/firmware/kernel/thread.c @@ -367,10 +367,6 @@ static void new_thread_base_init(struct thread_entry *thread, #ifdef HAVE_SCHEDULER_BOOSTCTRL thread->cpu_boost = 0; #endif -#ifdef HAVE_IO_PRIORITY - /* Default to high (foreground) priority */ - thread->io_priority = IO_PRIORITY_IMMEDIATE; -#endif } /*--------------------------------------------------------------------------- @@ -1421,20 +1417,6 @@ int thread_get_priority(unsigned int thread_id) } #endif /* HAVE_PRIORITY_SCHEDULING */ -#ifdef HAVE_IO_PRIORITY -int thread_get_io_priority(unsigned int thread_id) -{ - struct thread_entry *thread = __thread_id_entry(thread_id); - return thread->io_priority; -} - -void thread_set_io_priority(unsigned int thread_id,int io_priority) -{ - struct thread_entry *thread = __thread_id_entry(thread_id); - thread->io_priority = io_priority; -} -#endif - /*--------------------------------------------------------------------------- * Starts a frozen thread - similar semantics to wakeup_thread except that * the thread is on no scheduler or wakeup queue at all. It exists simply by -- cgit v1.2.3