From 672bbe434b12d4730cf270f7245753fb98cf162d Mon Sep 17 00:00:00 2001 From: Aidan MacDonald Date: Sun, 19 Sep 2021 10:54:26 +0100 Subject: usb: rename usb_drv_recv() to usb_recv_recv_nonblocking() IMHO the current name is somewhat misleading: - usb_drv_send() is blocking and we have usb_drv_send_nonblocking() for the non-blocking case. This inconsistent naming can only promote confusion. (And what would we call a blocking receive?) - Other hardware abstraction APIs in Rockbox are usually blocking: storage, LCD, backlight, audio... in other words, blocking is the default expected behavior, with non-blocking calls being a rarity. Change-Id: I05b41088d09eab582697674f4f06fdca0c8950af --- firmware/export/usb_drv.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'firmware/export') diff --git a/firmware/export/usb_drv.h b/firmware/export/usb_drv.h index 7ef7c8b7ee..01535c2786 100644 --- a/firmware/export/usb_drv.h +++ b/firmware/export/usb_drv.h @@ -68,8 +68,7 @@ void usb_drv_stall(int endpoint, bool stall,bool in); bool usb_drv_stalled(int endpoint,bool in); int usb_drv_send(int endpoint, void* ptr, int length); int usb_drv_send_nonblocking(int endpoint, void* ptr, int length); -int usb_drv_recv(int endpoint, void* ptr, int length); -void usb_drv_ack(struct usb_ctrlrequest* req); +int usb_drv_recv_nonblocking(int endpoint, void* ptr, int length); void usb_drv_set_address(int address); void usb_drv_reset_endpoint(int endpoint, bool send); bool usb_drv_powered(void); -- cgit v1.2.3