From c4156b1909175cd74154fa4217be053c1180ae9c Mon Sep 17 00:00:00 2001 From: William Wilgus Date: Sun, 17 Apr 2022 10:36:33 -0400 Subject: viewports, set flags to VP_DEFAULT_FLAGS flags were getting un-initialized memory it really didn't matter with the flags getting initialized anyway But once I added a new flag that didn't explicitly set or clear the flag at init well here we are set flags to VP_DEFAULT_FLAGS in viewport_set_defaults() add the flags variable to the default vp's set to 0 (it was already initialized to 0 by bss, make it explicit) Change-Id: I3a9a062455b4cf66d2b8c70fdf05402a5c0c091c --- firmware/export/lcd.h | 2 ++ 1 file changed, 2 insertions(+) (limited to 'firmware/export/lcd.h') diff --git a/firmware/export/lcd.h b/firmware/export/lcd.h index 2f8fd3e751..0edef7b866 100644 --- a/firmware/export/lcd.h +++ b/firmware/export/lcd.h @@ -182,6 +182,8 @@ struct frame_buffer_t { #define VP_FLAG_VP_DIRTY 0x4000 #define VP_FLAG_CLEAR_FLAG 0x8000 #define VP_FLAG_VP_SET_CLEAN (VP_FLAG_CLEAR_FLAG | VP_FLAG_VP_DIRTY) +/* flags set by viewport_set_defaults() */ +#define VP_DEFAULT_FLAGS (VP_FLAG_VP_DIRTY) struct viewport { int x; -- cgit v1.2.3