From b0a8cacd1dd11dbf6f8f7b46675d89e5b5b32920 Mon Sep 17 00:00:00 2001 From: Aidan MacDonald Date: Sat, 30 Mar 2024 15:02:22 +0000 Subject: rolo: simplify parsing scramble header in load_firmware() The standard load_firmware() function is used on targets which use the "scramble -add" method for generating Rockbox binaries. While it tries to be a bit more generic and allows the CRC/data offsets to be placed anywhere in the file, there are no targets which actually need this flexibility, because they are all using plain old "scramble -add". So we can actually simplify load_firmware() and remove defines from the target headers. All the targets used CRC offset = 0 and data offset = 8, except for a few which I assume never supported ROLO or were never tested -- eg. samsungyh820: the CRC and data offsets cannot both be 0. The actual motivation for this is removing the calls to lseek(), which can help make bootloaders a tiny bit smaller, as lseek is typically not used anywhere else in bootloaders. Change-Id: Ic2d01e5b75a32e88363f085e3e839146a0710bf4 --- firmware/export/config/creativezen.h | 5 ----- 1 file changed, 5 deletions(-) (limited to 'firmware/export/config/creativezen.h') diff --git a/firmware/export/config/creativezen.h b/firmware/export/config/creativezen.h index a3bb3a0ac6..b1f438c354 100644 --- a/firmware/export/config/creativezen.h +++ b/firmware/export/config/creativezen.h @@ -171,11 +171,6 @@ /* Type of LCD */ #define CONFIG_LCD LCD_CREATIVEZEN -/* Offset ( in the firmware file's header ) to the file CRC and data. These are - only used when loading the old format rockbox.e200 file */ -#define FIRMWARE_OFFSET_FILE_CRC 0x0 -#define FIRMWARE_OFFSET_FILE_DATA 0x8 - /* USB On-the-go */ #define CONFIG_USBOTG USBOTG_ARC -- cgit v1.2.3