From c6299b268da0599c2bbce3e71efb5398ffd0a808 Mon Sep 17 00:00:00 2001 From: Michael Sevakis Date: Sat, 21 Jan 2017 08:09:48 -0500 Subject: action.c must desist in calling set_cpu_frequency from a tick The function is neither reentrant nor ISR callable. Instead of using a ticked-based timeout, have the button driver provide the unboost after a delay when waiting for a button. HAVE_GUI_BOOST gets immediate boost after dequeuing any message, otherwise the queue has to have at least three messages waiting for it to trigger a boost-- essentially the behavior that existed but now combined in one place. Change-Id: I1d924702840f56a1a65abe41fa92b4e753c4e75a --- firmware/export/config.h | 5 ----- 1 file changed, 5 deletions(-) (limited to 'firmware/export/config.h') diff --git a/firmware/export/config.h b/firmware/export/config.h index 73464526a6..e7cfc698df 100644 --- a/firmware/export/config.h +++ b/firmware/export/config.h @@ -1129,11 +1129,6 @@ Lyre prototype 1 */ #define INCLUDE_TIMEOUT_API #endif /* HAVE_USB_CHARGING_ENABLE && HAVE_USBSTACK */ -#if defined(HAVE_GUI_BOOST) && defined(HAVE_ADJUSTABLE_CPU_FREQ) -/* Timeout objects required if GUI boost is enabled */ -#define INCLUDE_TIMEOUT_API -#endif /* HAVE_GUI_BOOST && HAVE_ADJUSTABLE_CPU_FREQ */ - #ifndef SIMULATOR #if defined(HAVE_USBSTACK) || (CONFIG_STORAGE & STORAGE_NAND) #define STORAGE_GET_INFO -- cgit v1.2.3