From 6f0320a9535bc1aa81d83fa879ac14d5ee603658 Mon Sep 17 00:00:00 2001 From: William Wilgus Date: Fri, 27 Jul 2018 23:56:32 +0200 Subject: As3525 v1/v2 Add power savings menu Allow user to select cpu undervolt There have been quite a few issues across the SANSA AMS line related to CPU undervolting while most players show greatly increased runtime some crash. Rather than constanly upping the voltage we now have a setting with a safe value for all players and the option for lower voltages I plan to add a few other options here later such as disk timings and maybe some other clocks/experimental settings Added: Disk Low speed option for AS3525v2 devices cuts frequency to 12 MHz from 24 MHz Added: Disk Low speed option for AS3525v1 devices cuts frequency to 15.5 MHz from 31 MHz Added: I2c Low Speed AS3525 devices, should be bigger improvement for v1 devices Fixed: Debug menu for AS3525v2 No SDSLOT frequency, Showed IDE freq though it is unused Added: DBOP and SSP underclocking affects display on v1/v2 respectively Fixed: debug menu now has SSP frequency, and SSP_CPSR Update: made settings menu more generic Update: cleaned up code Added: Clip v1 & Fuze v1 didn't have HAVE_ADJUSTABLE_CPU_VOLTAGE. not sure why but, waiting on testing to confirm Added: C200v2 and E200v2 devices and HAVE_ADJUSTABLE_CPU_VOLTAGE. Fixed: v1 devices don't like display timing set lower (dbop) v1 devices don't have a divider set for ssp (causes divide by 0) Fixed: ClipZip display lags with Max SSP divider changed from 0xFE to 0x32 Fixed: v1 devices didn't work properly with highspeed sd cards Added code from http://gerrit.rockbox.org/r/#/c/1704/ Added powersave and IDE interface enable/disable Added: V2 devices now have powersave enabled on sd interface Update: cleaned up code, lang defines, added manual entries Update ssp clock mechanism added calculated ssp divider to clipzip Update turn display clock off when clip+ turns off display Fixed: clipzip wrong register for SSP clock Change-Id: I04137682243be92f0f8d8bf1cfa54fbb1965559b TODO: add other players? --- apps/features.txt | 4 ++++ apps/lang/english.lang | 51 ++++++++++++++++++++++++++++++++++++++++++++++ apps/menus/settings_menu.c | 35 +++++++++++++++++++++++++++++++ apps/settings.h | 19 +++++++++++++++++ apps/settings_list.c | 38 +++++++++++++++++++++++++++++++++- 5 files changed, 146 insertions(+), 1 deletion(-) (limited to 'apps') diff --git a/apps/features.txt b/apps/features.txt index 3c0b0a3856..39c8422fbd 100644 --- a/apps/features.txt +++ b/apps/features.txt @@ -288,3 +288,7 @@ play_frequency #if defined(HAVE_BOOTDATA) boot_data #endif + +#if defined(CONFIG_POWER_SAVING) +sys_powersaving +#endif diff --git a/apps/lang/english.lang b/apps/lang/english.lang index d4e0697667..fa1b5f2c27 100644 --- a/apps/lang/english.lang +++ b/apps/lang/english.lang @@ -13647,3 +13647,54 @@ *: "Disable Touch" + + id: LANG_POWER_SAVING_MENU + desc: system clock and voltage settings + user: core + + *: none + sys_powersaving: "Power Saving" + + + *: none + sys_powersaving: "Power Saving" + + + *: none + sys_powersaving: "Power Saving" + + + + id: LANG_CPU + desc: system clock and voltage settings + user: core + + *: none + sys_powersaving: "CPU" + + + *: none + sys_powersaving: "CPU" + + + *: none + sys_powersaving: "CPU" + + + + id: LANG_I2C + desc: system clock and voltage settings + user: core + + *: none + sys_powersaving: "I2C" + + + *: none + sys_powersaving: "I2C" + + + *: none + sys_powersaving: "I2C" + + diff --git a/apps/menus/settings_menu.c b/apps/menus/settings_menu.c index 5c99cb4cd4..f23f01d4dc 100644 --- a/apps/menus/settings_menu.c +++ b/apps/menus/settings_menu.c @@ -295,6 +295,36 @@ MAKE_MENU(disk_menu, ID2P(LANG_DISK_MENU), 0, Icon_NOICON, ); #endif +#ifdef CONFIG_POWER_SAVING +#if (CONFIG_POWER_SAVING & POWERSV_CPU) +MENUITEM_SETTING(cpu_powersave, &global_settings.cpu_powersave, NULL); +#endif +#if (CONFIG_POWER_SAVING & POWERSV_DISK) +MENUITEM_SETTING(disk_powersave, &global_settings.disk_powersave, NULL); +#endif +#if (CONFIG_POWER_SAVING & POWERSV_I2C) +MENUITEM_SETTING(i2c_powersave, &global_settings.i2c_powersave, NULL); +#endif +#if (CONFIG_POWER_SAVING & POWERSV_DISP) +MENUITEM_SETTING(disp_powersave, &global_settings.disp_powersave, NULL); +#endif + +MAKE_MENU(power_save_menu, ID2P(LANG_POWER_SAVING_MENU), 0, Icon_NOICON, +#if (CONFIG_POWER_SAVING & POWERSV_CPU) + &cpu_powersave, +#endif +#if (CONFIG_POWER_SAVING & POWERSV_DISK) + &disk_powersave, +#endif +#if (CONFIG_POWER_SAVING & POWERSV_I2C) + &i2c_powersave, +#endif +#if (CONFIG_POWER_SAVING & POWERSV_DISP) + &disp_powersave, +#endif + ); +#endif /* ifdef CONFIG_POWER_SAVING */ + /* Limits menu */ MENUITEM_SETTING(max_files_in_dir, &global_settings.max_files_in_dir, NULL); MENUITEM_SETTING(max_files_in_playlist, &global_settings.max_files_in_playlist, NULL); @@ -412,6 +442,11 @@ MAKE_MENU(system_menu, ID2P(LANG_SYSTEM), &disk_menu, #endif &limits_menu, + +#if defined(CONFIG_POWER_SAVING) + &power_save_menu, +#endif + #ifdef HAVE_QUICKSCREEN &shortcuts_replaces_quickscreen, #endif diff --git a/apps/settings.h b/apps/settings.h index 71233d904a..411675153a 100644 --- a/apps/settings.h +++ b/apps/settings.h @@ -860,6 +860,25 @@ struct user_settings int governor; int usb_mode; #endif + +#ifdef CONFIG_POWER_SAVING +#if (CONFIG_POWER_SAVING & POWERSV_CPU) + bool cpu_powersave; +#endif + +#if (CONFIG_POWER_SAVING & POWERSV_DISK) + bool disk_powersave; +#endif + +#if (CONFIG_POWER_SAVING & POWERSV_I2C) + bool i2c_powersave; +#endif + +#if (CONFIG_POWER_SAVING & POWERSV_DISP) + bool disp_powersave; +#endif +#endif /*defined(CONFIG_POWER_SAVING)*/ + }; /** global variables **/ diff --git a/apps/settings_list.c b/apps/settings_list.c index 57763d345a..fe280b0ff6 100644 --- a/apps/settings_list.c +++ b/apps/settings_list.c @@ -2246,7 +2246,43 @@ const struct settings_list settings[] = { ID2P(LANG_IBASSO_USB_MODE_CHARGE), ID2P(LANG_IBASSO_USB_MODE_ADB)), #endif -}; + +#ifdef CONFIG_POWER_SAVING +#if (CONFIG_POWER_SAVING & POWERSV_CPU) + OFFON_SETTING(0, + cpu_powersave, + LANG_CPU, + false, + "cpu powersave", + cpu_set_powersave), +#endif +#if (CONFIG_POWER_SAVING & POWERSV_DISK) + OFFON_SETTING(0, + disk_powersave, + LANG_DISK_MENU, + false, + "disk powersave", + disk_set_powersave), +#endif +#if (CONFIG_POWER_SAVING & POWERSV_DISP) + OFFON_SETTING(0, + disp_powersave, + LANG_DISPLAY, + false, + "disp powersave", + disp_set_powersave), +#endif +#if (CONFIG_POWER_SAVING & POWERSV_I2C) + OFFON_SETTING(0, + i2c_powersave, + LANG_I2C, + false, + "i2c powersave", + i2c_set_powersave), +#endif +#endif /*defined(CONFIG_POWER_SAVING)*/ + +};/*struct settings_list settings*/ const int nb_settings = sizeof(settings)/sizeof(*settings); -- cgit v1.2.3