From fa0cecf5a9fe309e445f6146c2c49c3205ebc85e Mon Sep 17 00:00:00 2001 From: Miika Pekkarinen Date: Sat, 20 Aug 2005 18:49:14 +0000 Subject: Fixed a bug that caused codec memory allocation buffer overwrite and vorbis codec to crash. git-svn-id: svn://svn.rockbox.org/rockbox/trunk@7362 a1c6a512-1295-4272-9138-f99709370657 --- apps/talk.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'apps/talk.c') diff --git a/apps/talk.c b/apps/talk.c index b417046a61..a1a33bb7c8 100644 --- a/apps/talk.c +++ b/apps/talk.c @@ -210,8 +210,7 @@ static void load_voicefile(void) cpu_boost(true); buf = (unsigned char *)(&p_voicefile->index) + (p_voicefile->id1_max + p_voicefile->id2_max) * sizeof(struct clip_entry); - length = file_size - offsetof(struct voicefile, index) - - (p_voicefile->id1_max - p_voicefile->id2_max) * sizeof(struct clip_entry); + length = file_size - (buf - audiobuf); for (i = 0; i < length; i++) { -- cgit v1.2.3